Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AISEDetection per-bounding box method #55

Merged
merged 16 commits into from
Aug 29, 2024

Conversation

negvet
Copy link
Collaborator

@negvet negvet commented Aug 14, 2024

AISEDetection is an efficient black-box XAI method for object detection models, that support bounding boxes as targets.

image

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 98.12207% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.43%. Comparing base (4ce1903) to head (3243f39).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
openvino_xai/methods/black_box/aise/base.py 95.83% 1 Missing ⚠️
...nvino_xai/methods/black_box/aise/classification.py 98.30% 1 Missing ⚠️
openvino_xai/methods/black_box/aise/detection.py 98.97% 1 Missing ⚠️
openvino_xai/methods/factory.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #55      +/-   ##
===========================================
+ Coverage    92.76%   93.43%   +0.66%     
===========================================
  Files           23       25       +2     
  Lines         1424     1569     +145     
===========================================
+ Hits          1321     1466     +145     
  Misses         103      103              
Flag Coverage Δ
dev-py310 93.43% <98.12%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@negvet negvet marked this pull request as ready for review August 20, 2024 15:09
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for the new feature! It looks generally good to me.
BTW, I have a little concern about the metadata flow. Please see my comments.

README.md Show resolved Hide resolved
openvino_xai/methods/__init__.py Outdated Show resolved Hide resolved
openvino_xai/methods/base.py Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Outdated Show resolved Hide resolved
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great addition to our methods pull! Left some comments.

examples/run_detection.py Outdated Show resolved Hide resolved
openvino_xai/explainer/visualizer.py Outdated Show resolved Hide resolved
openvino_xai/explainer/visualizer.py Outdated Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Show resolved Hide resolved
tests/unit/methods/black_box/test_black_box_method.py Outdated Show resolved Hide resolved
openvino_xai/methods/black_box/aise.py Outdated Show resolved Hide resolved
goodsong81
goodsong81 previously approved these changes Aug 21, 2024
@negvet negvet merged commit 634caed into openvinotoolkit:develop Aug 29, 2024
6 checks passed
@goodsong81 goodsong81 added this to the 1.1.0 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants