-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PDPD]Added and fixed Paddle convert. #28347
[PDPD]Added and fixed Paddle convert. #28347
Conversation
build_jenkins |
Hi @ceciliapeng2011 Could you please take a review? Thanks! |
return res; | ||
} | ||
|
||
Output<Node> get_1d_tensor(const Output<Node>& node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you meet any problem here without inserting unsqueeze node when node_dim == 0? OpenVINO supports scalar (rank==0).
return res; | ||
} | ||
|
||
Output<Node> get_1d_tensor(const Output<Node>& node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name "get_1d_tensor" sounds a bit mis-leading - it does not turn any tensor to 1D, right?Suggest change to something like "get_tensor_safe".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Leave some minor comments.
build_jenkins |
value_node = opset6::Constant::create(dtype, {1}, {value}); | ||
value_node = opset6::Constant::create(dtype, {}, {value}); | ||
} else if (dtype == element::f64) { | ||
float value = static_cast<double>(node.get_attribute<float>("value")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
float value = static_cast<double>(node.get_attribute<float>("value")); | |
double value = static_cast<double>(node.get_attribute<float>("value")); |
It looks some windows building failure. @bukejiyu I show you the way to check the building logs. |
0dc5f4c
to
1553492
Compare
1553492
to
2f488af
Compare
build_jenkins |
### Details: 1. *added proto::AttrType::SCALARS* 2. support 0D inputs and fixes: - argmax:[argmax](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/argmax_en.html#argmax) - assign_value - divide:[divide](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/divide_en.html#divide) - fill_any_like:[full_like](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/full_like_en.html#full-like) - fill_constan:[full](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/full_en.html#full)\ - set_value - slice:[slice](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/slice_en.html#slice) - tile:[tile](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/tile_en.html#tile) 3. Added convert: - abs:[abs](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/abs_en.html#abs) - argmin:[argmin](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/argmin_en.html#argmin) - scatter:[scatter](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/scatter_en.html#scatter) - scatter_nd_add:[scatter_nd_add](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/scatter_nd_add_en.html#scatter-nd-add) - take_along_axis:[take_along_axis](https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/take_along_axis_en.html#take-along-axis) ### Tickets: --------- Co-authored-by: cecilia peng <[email protected]> Co-authored-by: Yu Xu <[email protected]>
Details:
Tickets: