Enable CM kernels for GPU #27857
Enable CM kernels for GPU #27857
Conversation
* add example cm implementation for fully_connected
github-actions
bot
added
category: GPU
| @@ -154,7 +154,11 @@ void kernels_cache::get_program_source(const kernels_code& kernels_source_code, | |||
| std::string options = kernel_string->options; | |||
| bool batch_compilation = kernel_string->batch_compilation; | |||
|
|
|||
| if (batch_compilation) { | |||
| bool is_cm = options.find("-cmc") != std::string::npos; | |||
There was a problem hiding this comment.
Is it the only way to check that CM compiler is invoked?
There was a problem hiding this comment.
Yes, OpenCL runtime will use CM compiler only if the -cmc is present in options provided to clBuildProgram. This is the most straightforward way to check this. Alternatively, we can add is_cm flag to kernel_string (src/plugins/intel_gpu/include/intel_gpu/runtime/kernel_args.hpp) and set it for CM primitives during creation.
There was a problem hiding this comment.
Usually search in a string being inside a loop is not the most effective way from performance perspective. But overall impact for the app should not be visible I believe. So leaving this for OV guys to suggest.
There was a problem hiding this comment.
I think we may add enum like KernelLanguage {OCLC, CM} and make it a part of KernelCode structure
There was a problem hiding this comment.
I added the kernel_language enum to kernel_string in 472a46e. Because KernelCode struct from kernel_selector is not propagated to kernels_cache.
|
build_jenkins |
| @@ -154,7 +154,11 @@ void kernels_cache::get_program_source(const kernels_code& kernels_source_code, | |||
| std::string options = kernel_string->options; | |||
| bool batch_compilation = kernel_string->batch_compilation; | |||
|
|
|||
| if (batch_compilation) { | |||
| bool is_cm = options.find("-cmc") != std::string::npos; | |||
There was a problem hiding this comment.
I think we may add enum like KernelLanguage {OCLC, CM} and make it a part of KernelCode structure
|
build_jenkins |
|
build_jenkins |
|
build_jenkins |
| @@ -121,6 +121,47 @@ bool query_local_block_io_supported(engine& e, const ExecutionConfig& config) { | |||
|
|
|||
| namespace cldnn { | |||
|
|
|||
| bool check_cm_jit_support(cldnn::engine& e, const cldnn::ExecutionConfig& config) { | |||
There was a problem hiding this comment.
nit: please align the indentation with other code -- we don't use indentation for the content of namespace
There was a problem hiding this comment.
Done a875efa, dfafa15
|
build_jenkins |
|
build_jenkins |
### Details: - *Add CM implementation type* - *Reuse OCL logic with kernel selector, kernel cache and batch compilation for CM primitive implementations* - *Adjust primitive db and codegen logic to store CM sources separately from OCL C* - *Add example CM print kernel for fully_connected primitive with unit test* ### Tickets: - *[33449](https://jira.devtools.intel.com/browse/CVS-33449)* --------- Co-authored-by: Pavel Durandin <[email protected]>
This reverts commit af7a091.
Details:
Tickets: