Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT REVIEW][DO NOT MERGE] Removal ONNX dependency #27757

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[DO NOT REVIEW][DO NOT MERGE] Removal ONNX dependency #27757

wants to merge 15 commits into from
+985 −268

Conversation

gkrivor
Copy link
Contributor

@gkrivor gkrivor commented Nov 26, 2024

Details:

  • Testing removal of ONNX dependency

Tickets:

  • 157141

@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: ONNX FE OpenVINO ONNX FrontEnd category: dependency_changes Pull requests that update a dependency file labels Nov 26, 2024
p-wysocki
p-wysocki reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@p-wysocki p-wysocki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct that onnx.proto is a sufficient replacement for model generation instead of the thirdparty repository? If so, is the plan to keep it up to date manually together with Python package version bump?

@gkrivor
Copy link
Contributor Author

gkrivor commented Nov 26, 2024

Am I correct that onnx.proto is a sufficient replacement for model generation instead of the thirdparty repository? If so, is the plan to keep it up to date manually together with Python package version bump?

Yes and yes. But it is only a PoC right now

@gkrivor gkrivor marked this pull request as ready for review November 27, 2024 08:35
@gkrivor gkrivor requested review from a team as code owners November 27, 2024 08:35
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jan 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Jan 14, 2025
@gkrivor gkrivor reopened this Jan 14, 2025
@github-actions github-actions bot removed the Stale label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-wysocki p-wysocki p-wysocki left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: dependency_changes Pull requests that update a dependency file category: ONNX FE OpenVINO ONNX FrontEnd do_not_merge do_not_review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkrivor @p-wysocki