Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Fix mvn segmentation fault for multiple threads start_async #27654

Merged
merged 8 commits into from
Nov 25, 2024
Merged

[GPU] Fix mvn segmentation fault for multiple threads start_async #27654

merged 8 commits into from
Nov 25, 2024

Conversation

yuanxion
Copy link
Contributor

Details:

  • Deep copy impl params: deep copy primitive impl KernelData params for different networks when running start_async() with multi-threads (THROUGHPUT mode)

Tickets:

Migrated from PR #27263.

@yuanxion yuanxion marked this pull request as ready for review November 21, 2024 02:49
@yuanxion yuanxion requested a review from a team as a code owner November 21, 2024 02:49
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Nov 21, 2024
@yuanxion yuanxion requested a review from a team as a code owner November 21, 2024 02:49
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Nov 21, 2024
@vladimir-paramuzov vladimir-paramuzov added this to the 2024.6 milestone Nov 21, 2024
@vladimir-paramuzov
Copy link
Contributor

build_jenkins

@yuanxion
Fix segmentation fault in mvn update_shapes
75295ea 
Signed-off-by: yuan.xiong <[email protected]>
@yuanxion
Deep copy _impl params to avoid segmentation fault for start_async wi…
6ff1f42 
…th multi-threads under THROUGHPUT mode

Signed-off-by: yuan.xiong <[email protected]>
@yuanxion
Revert "Fix segmentation fault in mvn update_shapes"
8833eba 
This reverts commit 27ddd4d.
@yuanxion
Clone KernelData params for cloned impl in clone_kernel_data_params
8acbd27 
Signed-off-by: yuan.xiong <[email protected]>
@yuanxion
Refine code to make deep code of impl Kernel Data params
3c0b229 
Signed-off-by: yuan.xiong <[email protected]>
@yuanxion
Make deep copy of impl Kernel Data params for more ocl impls
2cf0015 
Signed-off-by: yuan.xiong <[email protected]>
@yuanxion
Add missed ocl impls.
fd1b622 
Signed-off-by: yuan.xiong <[email protected]>
@yuanxion
Check data pointer after dynamic_cast
04750ed 
Signed-off-by: yuan.xiong <[email protected]>
@yuanxion yuanxion force-pushed the fix-segment-fault-mvn-rc branch from 923aee1 to 04750ed Compare November 22, 2024 05:59
@sshlyapn
Copy link
Contributor

build_jenkins

@p-durandin p-durandin added this pull request to the merge queue Nov 25, 2024
Merged via the queue into openvinotoolkit:releases/2024/5 with commit c093ef5 Nov 25, 2024
151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-paramuzov vladimir-paramuzov vladimir-paramuzov approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin ExternalPR External contributor
Projects
None yet
Milestone
2024.6
Development

Successfully merging this pull request may close these issues.
5 participants
@yuanxion @vladimir-paramuzov @sshlyapn @p-durandin @sys-openvino-ci