Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] fix SDPA produce NaN after transpose_fusion pass. #27629

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[GPU] fix SDPA produce NaN after transpose_fusion pass. #27629

merged 2 commits into from
Dec 2, 2024

Conversation

timxu826
Copy link
Contributor

Details:

  • The issue only happens is fp16 model and even fp32 model if a hint for fp32 is not set.
  • The NaN starts to produce after the comit 27780a6 which reverts the fake alignment. CVS-155861

Tickets:

@timxu826 timxu826 requested review from a team as code owners November 20, 2024 04:13
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Nov 20, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalIntelPR External contributor from Intel label Nov 20, 2024
@sshlyapn
Copy link
Contributor

build_jenkins

@sshlyapn
Copy link
Contributor

@timxu826 , could you please add a test where some inputs are transposed and others are not?

@vladimir-paramuzov vladimir-paramuzov added this to the 2025.0 milestone Nov 20, 2024
@timxu826
Copy link
Contributor Author

@timxu826 , could you please add a test where some inputs are transposed and others are not?

No problem, will do.

@timxu826
Copy link
Contributor Author

transpose feature in testcase is added.

@timxu826
Copy link
Contributor Author

build_jenkins

@p-durandin
Copy link
Contributor

build_jenkins

@p-durandin p-durandin added Code Freeze backport label to backport PR to the release branch labels Nov 29, 2024
@geunhwan geunhwan added this pull request to the merge queue Dec 2, 2024
Merged via the queue into openvinotoolkit:master with commit 0d9d14d Dec 2, 2024
156 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-paramuzov vladimir-paramuzov vladimir-paramuzov approved these changes

@sshlyapn sshlyapn sshlyapn approved these changes

Assignees
No one assigned
Labels
backport label to backport PR to the release branch category: GPU OpenVINO GPU plugin Code Freeze ExternalIntelPR External contributor from Intel
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
6 participants
@timxu826 @sshlyapn @p-durandin @vladimir-paramuzov @geunhwan @sys-openvino-ci