Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] enable brdgmm kernel in CPU plugin #27589

Merged
merged 17 commits into from
Dec 9, 2024

Conversation

tiger100256-hu
Copy link
Contributor

@tiger100256-hu tiger100256-hu commented Nov 18, 2024

Details:

Tickets:

@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Nov 18, 2024
@tiger100256-hu tiger100256-hu marked this pull request as ready for review November 20, 2024 04:52
@tiger100256-hu tiger100256-hu requested review from a team as code owners November 20, 2024 04:52
@dmitry-gorokhov dmitry-gorokhov added this to the 2025.0 milestone Nov 20, 2024
@liubo-intel
Copy link
Contributor

A related question: since openvino always use fp32 type for bias on X86, while oneDNN brdgmm algo not support this kind of mixture precision. so even enabled brdgmm algorithm for openvino, this kind of kernel also can't be used for f16 infer precision(GNR platform)(details in ticket: CVS-157009).
f16 bias seems needed to support(maybe like current ARM platform way ) in order to use brdgmm f16 kernel.

Copy link
Contributor

@luweizhou2016 luweizhou2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let us check the perf data.

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Dec 9, 2024
Merged via the queue into openvinotoolkit:master with commit de949b4 Dec 9, 2024
169 checks passed
11happy pushed a commit to 11happy/openvino that referenced this pull request Dec 23, 2024
### Details:
 - *replace  impl string brdgmm with brgconv*
 - *add test case*
 - *remove skip CVS-56143 config, CVS-56143 is already closed*
 - *remove skip CVS-53578 config, CVS-53578 is already closed*
 - *use new ticket CVS-157596 to track leftover test case*

### Tickets:
 - *CVS-156792*

---------

Signed-off-by: HU Yuan2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants