Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPUW] Add a pass to convert convolutions to matmul #27487

Merged

Conversation

smirnov-alexey
Copy link
Contributor

No description provided.

@smirnov-alexey smirnov-alexey added category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin labels Nov 8, 2024
@smirnov-alexey smirnov-alexey requested review from a team as code owners November 8, 2024 15:44
@smirnov-alexey smirnov-alexey changed the title WIP: [NPUW] Add a pass to convert convolutions to matmul [NPUW] Add a pass to convert convolutions to matmul Nov 12, 2024
Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recommendations here:

  1. Please align the patterns according to feedback
  2. I will review the LT refactoring to make it a proper baseline here
  3. So we align the RESHAPE thing with the rest of the refactored code.

src/plugins/intel_npu/src/plugin/npuw/lazy_tensor.cpp Outdated Show resolved Hide resolved
src/plugins/intel_npu/src/plugin/npuw/util.cpp Outdated Show resolved Hide resolved
src/plugins/intel_npu/src/plugin/npuw/util.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks! If only we've had tests on this. 😬

Comment on lines +102 to +103
template <typename K>
V& at_or_at_or_at(const K& k1, const K& k2, const K& k3) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may continue forever, seems we need to introduce some monadic wrapper for at. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OR a variadic template could save the day here. BTW.

@dmatveev dmatveev added this pull request to the merge queue Nov 13, 2024
Merged via the queue into openvinotoolkit:master with commit 3d4f942 Nov 13, 2024
143 checks passed
@dmatveev dmatveev deleted the as/npuw_conv_to_matmul branch November 13, 2024 21:37
NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: NPU OpenVINO NPU plugin category: NPUW NPUW plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants