[ONNX] Added initial support of DequantizeLinear-21 #26915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: build
gkrivor
force-pushed
the
onnx_qdq21
branch
2 times, most recently
from
95d7a72 to
05f49a2
Compare
rkazants
reviewed
Oct 8, 2024
rkazants
reviewed
Oct 8, 2024
rkazants
reviewed
Oct 8, 2024
Removed commented code
rkazants
reviewed
Oct 16, 2024
| src_x.get_shape()[0] % block_size == 0, | ||
| "DequantizeLinear doesn't support case when first dimension of X cannot be divided by block_size"); | ||
|
|
||
| const auto& x = src_x.get_element_type() == scale_type ? src_x : std::make_shared<v1::ConvertLike>(src_x, scale); |
There was a problem hiding this comment.
can you please simplify? head breaking expression:)
There was a problem hiding this comment.
Ok, in a separate PR, CI is finally green
rkazants
reviewed
Oct 16, 2024
| FRONT_END_GENERAL_CHECK(scale_shape.rank().is_static(), "Rank of the input data tensor has to be known (static)."); | ||
| FRONT_END_GENERAL_CHECK(scale_shape.rank().get_length() == 2, | ||
| "DequantizeLinear cannot operate with more than 2D scales"); | ||
| FRONT_END_GENERAL_CHECK(src_x.get_partial_shape().is_static(), |
There was a problem hiding this comment.
really important limitation that can be often not met. We can think of how to support it via decomposition one more time, or request new op in the opset.
rkazants
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: