[NPUW] Recent coverity fix #26905
Merged
[NPUW] Recent coverity fix #26905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smirnov-alexey
added
category: NPU
AsyaPronina
reviewed
Oct 4, 2024
| @@ -473,7 +473,6 @@ DQMatMulGQiP::DQMatMulGQiP(Context::Ref ctx) { | |||
| auto qweight_shape = matched_qweight->output(0).get_shape(); | |||
| auto qcoeff_shape = matched_qcoeff->output(0).get_shape(); | |||
| auto act_shape = matched_out_mmi.get_shape(); | |||
| auto out_shape = matched_node_matmul->output(0).get_shape(); | |||
AsyaPronina
reviewed
Oct 4, 2024
| @@ -1034,10 +1032,10 @@ HostGather::HostGather(Context::Ref ctx) { | |||
| auto callback = [=](ov::pass::pattern::Matcher& m) { | |||
| auto& node_to_output = m.get_pattern_value_map(); | |||
| auto out_shape = node_to_output.at(qgthrw).get_shape(); | |||
| auto matched_out_qweight = node_to_output.at(qweight); | |||
| auto& matched_out_qweight = node_to_output.at(qweight); | |||
There was a problem hiding this comment.
shouldn't be const, yes?
There was a problem hiding this comment.
Not sure, coverity requested auto&
AsyaPronina
reviewed
Oct 4, 2024
| @@ -1173,8 +1171,6 @@ DQUnpackDictMatMulCWu::DQUnpackDictMatMulCWu(Context::Ref ctx) { | |||
| auto matched_result = std::static_pointer_cast<ov::op::v0::Result>(matched_node_res); | |||
|
|
|||
| auto qcoeff_shape = matched_qcoeff->output(0).get_shape(); | |||
| auto qzerop_shape = matched_qzerop->output(0).get_shape(); | |||
| auto act_shape = matched_mmi.get_shape(); | |||
|
|
|||
AsyaPronina
reviewed
Oct 4, 2024
| @@ -1228,8 +1224,7 @@ DQUnpackDictMatMulGQi::DQUnpackDictMatMulGQi(Context::Ref ctx) { | |||
| auto matched_matmul = std::static_pointer_cast<ov::op::v0::MatMul>(matched_node_matmul); | |||
| auto matched_result = std::static_pointer_cast<ov::op::v0::Result>(matched_node_res); | |||
|
|
|||
| auto qcoeff_shape = matched_qcoeff->output(0).get_shape(); | |||
| auto act_shape = matched_mmi.get_shape(); | |||
AsyaPronina
approved these changes
Oct 9, 2024
dmatveev
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.