Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] [GHA] Introduce additional Python (3.9-3.12) API tests on Ubuntu 22 #26897

Conversation

akashchi
Copy link
Contributor

@akashchi akashchi commented Oct 3, 2024

Tickets:

  • 152702

@akashchi akashchi added the WIP work in progress label Oct 3, 2024
@akashchi akashchi added this to the 2024.5 milestone Oct 3, 2024
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code category: dockerfiles labels Oct 3, 2024
@akashchi akashchi removed the WIP work in progress label Oct 8, 2024
@akashchi akashchi marked this pull request as ready for review October 8, 2024 10:22
@akashchi akashchi requested a review from a team as a code owner October 8, 2024 10:22
@@ -257,18 +248,6 @@ jobs:
export LD_LIBRARY_PATH=${INSTALL_TEST_DIR}:$LD_LIBRARY_PATH
python3 ${OPENVINO_REPO}/docs/articles_en/assets/snippets/main.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can also include Docs Python snippets to .github/workflows/job_python_api_tests.yml ? As they test OpenVINO API code snippets

python3.11-dev \
python3.11-venv \
python3.11-distutils \
python3.12-dev \
python3.12-venv \
python3.12-distutils \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to use manylinux docker image to build python versions. That docker image contains all the required python binaries for all OpenVINO supported versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manylinux introduction is tracked by a separate ticket (148719), @mryzhov might bring some insight on the progress/POC he did some time ago.

With this PR I was trying to match the test scope in Jenkins. I suggest we proceed with this approach as it introduces the tests in a separate workflow + the action for finding the right Python wheels, they could be adapted later when we have the manylinux introduced.

@akashchi akashchi requested a review from ilya-lavrenov October 8, 2024 14:10
@akashchi akashchi marked this pull request as draft October 15, 2024 13:01
@akashchi
Copy link
Contributor Author

Since we had an internal discussion, I think that this PR could be closed and its changes could be used later once the manylinux workflow is introduced.

@akashchi akashchi closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CI OpenVINO public CI category: dockerfiles github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants