Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Fix sd1.5_controlnet_lora bad image. #26881

Merged
merged 7 commits into from
Oct 14, 2024
Merged

[GPU] Fix sd1.5_controlnet_lora bad image. #26881

merged 7 commits into from
Oct 14, 2024

Conversation

hyunback
Copy link
Contributor

@hyunback hyunback commented Oct 2, 2024 •
edited
Loading

  1. Fixed a bug where dynamic tensor value would disappear when using dynamic and static inputs together.
  2. Fixed onednn gemm post-op wrong dims in case spatial 1x1.
  3. Fixed side effect for can_be_optimized condition in allocate_output . Skippable should be true for using mem pool.

Tickets:

  • 149836

@hyunback hyunback requested review from a team as code owners October 2, 2024 02:11
@hyunback hyunback added category: GPU OpenVINO GPU plugin WIP work in progress and removed WIP work in progress labels Oct 2, 2024
@hyunback hyunback force-pushed the fix_sd15_controlnet_lora_bad_image branch 2 times, most recently from de49000 to e5467b1 Compare October 10, 2024 02:28
@hyunback
[GPU] Fix sd1.5_controlnet_lora bad image.
db4362a 
1. Fixed a bug where dynamic tensor value would disappear when using dynamic and static inputs together.
2. Fixed onednn gemm post-op wrong dims in case spatial 1x1.
3. Fixed side effect for can_be_optimized condtion in  allocate_output .

Signed-off-by: hyunback <[email protected]>
@hyunback
Fix memory pool dependency issue.
620b122 
We should check is_runtime_skippable condition using memory pool.

Signed-off-by: hyunback <[email protected]>
@hyunback
Fix to use mem pool in default layer case..
8566cc5 
Signed-off-by: hyunback <[email protected]>
@hyunback
Fix unit-test failure.
ed0b51f 
Signed-off-by: hyunback <[email protected]>
@hyunback
Fix to use rank size instead of 4.
722ae15 
Signed-off-by: hyunback <[email protected]>
@hyunback
Fix concat handling with skippable enable.
6f1b5db 
Signed-off-by: hyunback <[email protected]>
@hyunback hyunback force-pushed the fix_sd15_controlnet_lora_bad_image branch from e5467b1 to 6f1b5db Compare October 10, 2024 08:00
@yeonbok yeonbok added this pull request to the merge queue Oct 14, 2024
Merged via the queue into openvinotoolkit:master with commit c44a32e Oct 14, 2024
142 checks passed
@hyunback hyunback deleted the fix_sd15_controlnet_lora_bad_image branch October 16, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-ddykim e-ddykim e-ddykim approved these changes

@yeonbok yeonbok yeonbok approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyunback @yeonbok @e-ddykim