Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate nop Convert at the beginning of the MOC pipeline #26872

Conversation

itikhono
Copy link
Contributor

@itikhono itikhono commented Oct 1, 2024

Details:

Added NopElimination at the beginning of the MOC
After pytorch conversion, we can see useless Convert (fp32 to fp32) in the graph

Constant (fp32) -> Node1
                -> Convert( to fp32) -> Node2

So after ConstantFolding, we will get

Constant (fp32) -> Node1
Constant (fp32) -> Node2

Deletion of the convert above fixes the duplication of the constant

Tickets:

@itikhono itikhono requested a review from a team as a code owner October 1, 2024 11:03
@github-actions github-actions bot added the category: transformations OpenVINO Runtime library - Transformations label Oct 1, 2024
@itikhono itikhono requested a review from jane-intel October 1, 2024 11:04
@itikhono itikhono changed the title Eliminate Convert fp32 to fp32 in MOC Eliminate nop Convert at the beginning of the MOC pipeline Oct 2, 2024
@itikhono itikhono added this pull request to the merge queue Oct 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 3, 2024
### Details:
Added NopElimination at the beginning of the MOC
After pytorch conversion, we can see useless Convert (fp32 to fp32) in
the graph
```
Constant (fp32) -> Node1
                -> Convert( to fp32) -> Node2
```
So after ConstantFolding, we will get
```
Constant (fp32) -> Node1
Constant (fp32) -> Node2
```
Deletion of the convert above fixes the duplication of the constant
                          
### Tickets:
 - *CVS-151490*
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@itikhono itikhono added this pull request to the merge queue Oct 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 4, 2024
### Details:
Added NopElimination at the beginning of the MOC
After pytorch conversion, we can see useless Convert (fp32 to fp32) in
the graph
```
Constant (fp32) -> Node1
                -> Convert( to fp32) -> Node2
```
So after ConstantFolding, we will get
```
Constant (fp32) -> Node1
Constant (fp32) -> Node2
```
Deletion of the convert above fixes the duplication of the constant
                          
### Tickets:
 - *CVS-151490*
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@itikhono
Copy link
Contributor Author

itikhono commented Oct 4, 2024

TensorFlow2 Layer Tests failed in post-commit, investigating

@itikhono
Copy link
Contributor Author

itikhono commented Oct 4, 2024

waiting for #26912

@dorloff dorloff added this pull request to the merge queue Oct 7, 2024
Merged via the queue into openvinotoolkit:master with commit e2c3982 Oct 7, 2024
157 checks passed
pkowalc1 pushed a commit to pkowalc1/openvino that referenced this pull request Oct 9, 2024
…oolkit#26872)

### Details:
Added NopElimination at the beginning of the MOC
After pytorch conversion, we can see useless Convert (fp32 to fp32) in
the graph
```
Constant (fp32) -> Node1
                -> Convert( to fp32) -> Node2
```
So after ConstantFolding, we will get
```
Constant (fp32) -> Node1
Constant (fp32) -> Node2
```
Deletion of the convert above fixes the duplication of the constant
                          
### Tickets:
 - *CVS-151490*

---------

Co-authored-by: Ilya Lavrenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants