Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Validate pass handling in pass::Manager #26705

Closed
wants to merge 13 commits into from
Closed

Fixed Validate pass handling in pass::Manager #26705

wants to merge 13 commits into from

Conversation

itikhono
Copy link
Contributor

Details:

Fixed Validate pass handling in pass::Manager

Tickets:

@itikhono itikhono requested review from a team as code owners September 20, 2024 08:53
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: transformations OpenVINO Runtime library - Transformations category: CPP API OpenVINO CPP API bindings labels Sep 20, 2024
@itikhono
Copy link
Contributor Author

According to additional validation runs, compile times with these changes increased by 3 times.
Investigating

@itikhono
Copy link
Contributor Author

itikhono commented Oct 2, 2024

the previous measurements were incorrect.
total compilation time (sum) for all models increased by 5%.
on some models there are degradations up to 10-15%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Nov 1, 2024
@itikhono itikhono mentioned this pull request Nov 7, 2024
Merged
@github-actions github-actions bot removed the Stale label Nov 9, 2024
@itikhono
Copy link
Contributor Author

itikhono commented Dec 10, 2024 •
edited
Loading

after the internal discussion, we decided to merge this PR.
The degradation of compilation_time on qwen model (+10-13%) is expected.

@itikhono
Copy link
Contributor Author

the test failure on Debian ARM is not sporadic, investigating

@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Dec 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnasm1 barnasm1 barnasm1 approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: transformations OpenVINO Runtime library - Transformations do_not_merge Stale under_perf_check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itikhono @t-jankowski @barnasm1 @evkotov