[core] Preserve friendly name and tensor names in PPP #23713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when PPP convert results or convert precision is applied
github-actions
bot
added
category: Core
MaximProshin
requested review from
alexsu52
and removed request for
MaximProshin
github-actions
bot
added
category: Python API
t-jankowski
approved these changes
Oct 28, 2024
…nsor-descriptor-for-results
- add UnrollIf to check tensor names are not lost if body model is Parameter -> Result Signed-off-by: Raasz, Pawel <[email protected]>
…or-for-results' into bugfix/fix-ppp-dereferences-input-tensor-names
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
### Details: - Introduce shared tensor descriptor: - It has specific tensor names. - When specific tensor names set they will be used as tensor names otherwise the shred tensor names are used. - Specific tensor names will be added to shared descriptor (input descriptor), and transferred to new tensor descriptor if changed. - Use shared tensor descriptor for Result, which got specific tensor names. - Add dev API Extension interface for descriptor::Tensor for internal OV use. - Update `ReverseShapeAndTypeInfer` to use descriptor interface instead change properties directly. Update `PartialShape` of descriptor can change it in undefined state with `Shape` property. - Improves tensor names handling for model outputs introduced in #23713 - Fix tensor names issue in `unroll_if` transformation (ticket: 114763) ### Tickets: - CVS-143105 - CVS-146649 - CVS-114763 ### Blocked by: - intel-innersource/frameworks.ai.openvino.tests#1684 - fixes e2e tests --------- Signed-off-by: Raasz, Pawel <[email protected]>
…ferences-input-tensor-names
…ferences-input-tensor-names
github-actions
bot
removed
category: inference
Signed-off-by: Raasz, Pawel <[email protected]>
ilya-lavrenov
added a commit
that referenced
this pull request
Dec 13, 2024
This reverts commit f1cba31.
11happy
pushed a commit
to 11happy/openvino
that referenced
this pull request
Dec 23, 2024
### Details: - Introduce shared tensor descriptor: - It has specific tensor names. - When specific tensor names set they will be used as tensor names otherwise the shred tensor names are used. - Specific tensor names will be added to shared descriptor (input descriptor), and transferred to new tensor descriptor if changed. - Use shared tensor descriptor for Result, which got specific tensor names. - Add dev API Extension interface for descriptor::Tensor for internal OV use. - Update `ReverseShapeAndTypeInfer` to use descriptor interface instead change properties directly. Update `PartialShape` of descriptor can change it in undefined state with `Shape` property. - Improves tensor names handling for model outputs introduced in openvinotoolkit#23713 - Fix tensor names issue in `unroll_if` transformation (ticket: 114763) ### Tickets: - CVS-143105 - CVS-146649 - CVS-114763 ### Blocked by: - intel-innersource/frameworks.ai.openvino.tests#1684 - fixes e2e tests --------- Signed-off-by: Raasz, Pawel <[email protected]>
11happy
pushed a commit
to 11happy/openvino
that referenced
this pull request
Dec 23, 2024
…t#23713) ### Details: - For models with `version > 10` the node's friendly name and tensor's names will be not moved from original node. If conversion node added by PPP or convert precision then new friendly name will be created based on previous node. The new node name will have format `[previous_node_name].[port_number]`. - Align `ConvertPrecision` transformation to with PPP - The issue with lost tensor names when set them on model's inputss/outputs has been solved in openvinotoolkit#25954 - For model version 10 the old behavior is preserved as legacy compatibility mode ### Tickets: - [CVS-127482](https://jira.devtools.intel.com/browse/CVS-127482) ### Depends on: - openvinotoolkit#25954 - implements tensor names handling for model outputs (should be used here) --------- Signed-off-by: Raasz, Pawel <[email protected]> Co-authored-by: Michal Lukaszewski <[email protected]> Co-authored-by: Anastasia Kuporosova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
version > 10the node's friendly name and tensor's names will be not moved from original node. If conversion node added by PPP or convert precision then new friendly name will be created based on previous node. The new node name will have format[previous_node_name].[port_number].ConvertPrecisiontransformation to with PPPTickets:
Depends on: