Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ov::serialize(model) does not report when file writing fails #23281

Closed
wants to merge 39 commits into from
Closed

[Bug]: ov::serialize(model) does not report when file writing fails #23281

wants to merge 39 commits into from

Conversation

mishra-18
Copy link

@mishra-18 mishra-18 commented Mar 5, 2024 •
edited by ilya-lavrenov
Loading

Details:

  • std::ofstream doesn't throw any exceptions by default. Added bin_file.exceptions and xml_file.exceptions to resolve it
  • file_path: openvino/src/core/src/pass/serialize.cpp

Tickets:

@mishra-18 mishra-18 requested a review from a team as a code owner March 5, 2024 15:57
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Mar 5, 2024
@mishra-18 mishra-18 changed the title [Good First Issue][Bug]: ov::serialize(model) does not report when file writing fails [Bug]: ov::serialize(model) does not report when file writing fails Mar 5, 2024
@mlukasze mlukasze mentioned this pull request Mar 6, 2024
Open
@vurusovs vurusovs self-assigned this Mar 6, 2024
@vurusovs vurusovs added this to the 2024.1 milestone Mar 6, 2024
ilya-lavrenov
ilya-lavrenov reviewed Mar 6, 2024
View reviewed changes
src/core/src/pass/serialize.cpp Outdated Show resolved Hide resolved
src/core/src/pass/serialize.cpp Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov added the ExternalPR External contributor label Mar 6, 2024
vurusovs
vurusovs suggested changes Mar 6, 2024
View reviewed changes
src/core/src/pass/serialize.cpp Outdated Show resolved Hide resolved
src/core/src/pass/serialize.cpp Outdated Show resolved Hide resolved
@mishra-18 mishra-18 requested a review from vurusovs March 7, 2024 14:01
vurusovs
vurusovs previously requested changes Mar 8, 2024
View reviewed changes
src/core/src/pass/serialize.cpp Outdated Show resolved Hide resolved
src/core/src/pass/serialize.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Apr 4, 2024
@mlukasze mlukasze removed this from the 2024.1 milestone Apr 4, 2024
@github-actions github-actions bot removed the Stale label Apr 5, 2024
@mishra-18 mishra-18 requested a review from a team as a code owner April 11, 2024 14:06
@mishra-18 mishra-18 requested review from itikhono and removed request for a team April 11, 2024 14:06
@github-actions github-actions bot removed the Stale label Sep 18, 2024
@mlukasze mlukasze enabled auto-merge September 18, 2024 05:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Oct 3, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Oct 3, 2024

@mishra-18
please solve conflicts, then we will run test suite again

@github-actions github-actions bot removed the Stale label Oct 4, 2024
auto-merge was automatically disabled October 7, 2024 09:50

Head branch was pushed to by a user without write access

@mlukasze mlukasze removed this from the 2024.4 milestone Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Nov 1, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Nov 4, 2024

build_jenkins

@github-actions github-actions bot removed the Stale label Nov 5, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Nov 6, 2024

build_jenkins

@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Nov 21, 2024
@mlukasze
Copy link
Contributor

build_jenkins

@mlukasze
Copy link
Contributor

@olpipi @praasz please help to @mishra-18 to solve problems found by CI

@praasz
Copy link
Contributor

praasz commented Nov 21, 2024

build_jenkins

@github-actions github-actions bot removed the Stale label Nov 22, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Dec 5, 2024

build_jenkins

@mlukasze mlukasze closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vurusovs vurusovs vurusovs left review comments

@praasz praasz praasz approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

@olpipi olpipi Awaiting requested review from olpipi

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov

Assignees

@t-jankowski t-jankowski

@praasz praasz

Labels
category: Core OpenVINO Core (aka ngraph) ExternalPR External contributor
Projects
Good first issues
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Good First Issue][Bug]: ov::serialize(model) does not report when file writing fails
8 participants
@mishra-18 @mlukasze @p-durandin @praasz @ilya-lavrenov @olpipi @vurusovs @t-jankowski