Enable some windows compiler flags #2964
Open
+513
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkulakowski
changed the title
rasapala
reviewed
Jan 14, 2025
common_settings.bzl
Outdated
| "/analyze", | ||
| "/Gy", | ||
| "/DYNAMICBASE", | ||
| #"/NXCOMPAT", |
rasapala
reviewed
Jan 14, 2025
| @@ -30,7 +32,7 @@ | |||
| namespace py = pybind11; | |||
|
|
|||
| namespace ovms { | |||
| Status PythonInterpreterModule::start(const ovms::Config& config) { | |||
| Status PythonInterpreterModule::start(const ovms::Config&) { | |||
There was a problem hiding this comment.
Can we remove this parameter? Why empty? Unused variable?
michalkulakowski
force-pushed
the
mkulakow/windows_compiler_flags
branch
4 times, most recently
from
71cb1d0 to
a0faf81
Compare
michalkulakowski
changed the title
michalkulakowski
force-pushed
the
mkulakow/windows_compiler_flags
branch
4 times, most recently
from
3f87145 to
3f6ce45
Compare
michalkulakowski
force-pushed
the
mkulakow/windows_compiler_flags
branch
from
5c1a8f0 to
3b384da
Compare
michalkulakowski
force-pushed
the
mkulakow/windows_compiler_flags
branch
from
53a3701 to
e3da189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
154694
154693
🧪 Checklist
``