Minor coverity fixes #2677
Open
Minor coverity fixes #2677
+107
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atobiszei
force-pushed
the
atobisze_coverity_minor_fixes
branch
5 times, most recently
from
21ba68c
to
6f87458
Compare
atobiszei
force-pushed
the
atobisze_coverity_minor_fixes
branch
from
6f87458
to
c80fa8a
Compare
rasapala
approved these changes
Sep 12, 2024
dkalinowski
reviewed
Sep 12, 2024
| @@ -296,7 +296,7 @@ class MediapipeGraphExecutor { | |||
| numberOfPacketsCreated), | |||
| "partial deserialization of subsequent requests", isSuccess); | |||
| } else { | |||
| OVMS_WRITE_ERROR_ON_FAIL_AND_CONTINUE(pstatus, "validate subsequent requests", isSuccess); | |||
| OVMS_WRITE_ERROR_ON_FAIL_AND_CONTINUE(std::move(pstatus), "validate subsequent requests", isSuccess); | |||
There was a problem hiding this comment.
Is it safe to use std move here? In case this macro will ever use first parameter twice, the pstatus will get moved twice, which is undefined behavior @atobiszei
There was a problem hiding this comment.
it is assigned to new variable,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``