Introduces input macros #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukhnos
requested changes
Dec 11, 2023
README.md
Outdated
| @@ -35,6 +35,12 @@ sudo apt install \ | |||
| cmake extra-cmake-modules gettext libfmt-dev | |||
There was a problem hiding this comment.
Nit: should we just add libicu-dev here? Since we are already telling people they need to install those -dev packages here…
The branch was merged. |
lukhnos
approved these changes
Dec 12, 2023
xatier
reviewed
Dec 14, 2023
| @@ -4,5 +4,5 @@ rm -rf build | |||
| mkdir -p build | |||
| cd build | |||
| cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Debug # use Debug for easy debugging with gdb | |||
| make # or ninja, depending on your system | |||
| sudo make install # or sudo ninja install | |||
| make # or ninja, depending on your system | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces input macros. Input macros are candidates that would be
replace dynamically by the input engine. We use input macros to input date and
time since a user might be hardly to remember the current date (especially in
the traditional Chinese calendar such as 癸卯年).
Currently, it supports the following input macros:
The localized dates are powered by ICU, so ICE becomes a dependency.