Add clang-tidy to CMakeLists.txt files
#82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clang-tidy` is a great tool to catch bugs at compile time. This commit adds support to execute `clang-tidy` to our CMake scripts. This flag is OFF by default, to enable clang-tidy, append `-DENABLE_CLANG_TIDY=On` to `cmake` commands. I picked a few popular ones, and we may want to enable more later. https://releases.llvm.org/11.1.0/tools/clang/tools/extra/docs/clang-tidy/checks/list.html
|
@lukhnos please kindly take a look. Hopefully, we can spot some bugs or improve our codebase w/ This set of check rules found quite a bit of issues, if time permits, I may submit subsequent PRs to fix them. |
lukhnos
approved these changes
Aug 11, 2023
|
Thank you! I really appreciate this effort to make the checks part of the build process. |
|
NP! I will find some time to resolve these issues reported by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-tidyis a great tool to catch bugs at compile time. This commit adds support to executeclang-tidyto our CMake scripts.This flag is OFF by default, to enable clang-tidy, append
-DENABLE_CLANG_TIDY=Ontocmakecommands.I picked a few popular ones, and we may want to enable more later.
https://releases.llvm.org/11.1.0/tools/clang/tools/extra/docs/clang-tidy/checks/list.html