Added DistributionBayesianNetwork #96
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class allows to create and manipulate general continuous bayesian networks given a DAG and a set of distributions for each node. For nodes without parents, the distribution is its marginal distribution, for the other nodes it is a way to define the conditional distribution of the node given its parents.
regislebrun
force-pushed
the
distribution_bn
branch
from
ec0a06c
to
fa8ccb7
Compare
jschueller
reviewed
Oct 3, 2024
| extracted. The scope of each copula is the node and its parents. | ||
|
|
||
| Available constructor: | ||
| DistributionBayesianNetwork(*dag, marginals, copulas*) |
There was a problem hiding this comment.
This can be dropped as there is only 1 ctor (its incorrect anyway)
jschueller
reviewed
Oct 3, 2024
|
|
||
| using OT::ContinuousDistribution::getMarginal; | ||
| OT::Distribution getMarginal(const OT::UnsignedInteger i) const override; | ||
|
|
There was a problem hiding this comment.
getparameter/setParameter/getParameterDescription accessors are missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class allows to create and manipulate general continuous bayesian networks given a DAG and a set of distributions for each node. For nodes without parents, the distribution is its marginal distribution, for the other nodes it is a way to define the conditional distribution of the node given its parents.