-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap out yarn for pnpm #795
base: master
Are you sure you want to change the base?
Swap out yarn for pnpm #795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have it auto-prepublish again? Also can we make sure that published packages refer to actual package versions and not the workspace things
From the docs: |
|
Things are looking much better. Is there any way we can update the yarn prepublish to add a warning about using pnpm instead? |
BREAKING CHANGE: maplibre-gl is no longer a direct dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need update-internal-dependencies.js
?
@@ -24,18 +24,7 @@ See: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few missing reference changes in here, especially around workspace package version management
Seeing this error when trying to import in otp-rr:
|
Yarn 1 has been unsupported for a while, with the last update 3 years ago. The biggest problem with running such an old version is that we are missing out on the more ergonomic ways of referencing internal dependencies.
Instead of needing to stay on top of internal dependency versions, we can now just reference
workspace:*
as our version number for any internal dependency.