fix(tree-select): [tree-select] fix tree-select can't load data dynamically close #2287 #2500
Conversation
WalkthroughThe changes in this pull request involve an update to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
kagol
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
packages/renderless/src/tree-select/vue.ts (1)
Line range hint
8-11: Consider adding loading and error statesFor better UX during dynamic data loading, consider adding loading and error states to the reactive state object:
const state = reactive({ value: computed(() => props.modelValue), - treeData: props.treeOp.data + treeData: props.treeOp.data, + isLoading: false, + error: null })This would allow consumers to show loading indicators or error messages when dynamic data loading is in progress or fails.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
packages/renderless/src/tree-select/vue.ts(2 hunks)
🧰 Additional context used
🪛 Biome
packages/renderless/src/tree-select/vue.ts
[error] 22-22: The assignment should not be in an expression.
The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.
(lint/suspicious/noAssignInExpressions)
🔇 Additional comments (2)
packages/renderless/src/tree-select/vue.ts (2)
5-5: LGTM: Appropriate addition of watch API
The addition of the watch API to the function signature follows Vue.js best practices and is necessary for implementing dynamic data loading functionality.
20-24: 🛠️ Refactor suggestion
Improve watch implementation robustness and readability
The current watch implementation has several potential issues:
- Assignment within expression reduces code clarity
- Lacks type validation for incoming data
- Deep watching might be unnecessary if data is primitive
Consider this more robust implementation:
watch(
() => props.treeOp.data,
- (data) => data && (state.treeData = data),
+ (data) => {
+ if (data === undefined || data === null) {
+ return;
+ }
+ state.treeData = data;
+ },
- { immediate: true, deep: true }
+ { immediate: true }
)Let's verify if deep watching is actually needed:
🧰 Tools
🪛 Biome
[error] 22-22: The assignment should not be in an expression.
The use of assignments in expressions is confusing.
Expressions are often considered as side-effect free.
(lint/suspicious/noAssignInExpressions)
| watch( | ||
| () => props.treeOp.data, | ||
| (data) => data && (state.treeData = data), | ||
| { immediate: true, deep: true } |
There was a problem hiding this comment.
这段代码是从select组件迁移的，后续如果遇到大数据场景再进行优化处理
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2287
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes