docs(playground): playground only supply latest 3 version #2488
Conversation
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
examples/sites/playground/App.vue (1)
43-65: Enhance notification accessibility and consistencyConsider the following improvements:
- Add ARIA labels for better accessibility
- Consider internationalizing the messages for consistency
Apply this diff to enhance the notification:
notify = Notify({ type: 'info', - title: '温馨提示：', + title: 'Notice:', message: () => ( <div> - <div>演练场仅保留最新的三个版本可选。</div> + <div role="alert" aria-live="polite"> + Only the latest three versions are available in the playground. + </div> <div style="text-align: right;margin-top: 12px;"> <TinyButton onClick={muteNotify} type={'primary'}> - 不再提示 + Don't show again </TinyButton> </div> </div> ), duration: -1, position: 'top-right', verticalOffset: 200 })
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
examples/sites/playground/App.vue(4 hunks)
🧰 Additional context used
🪛 eslint
examples/sites/playground/App.vue
[error] 87-88: Replace ⏎······@opentiny/vue-design-${tinyTheme}with@opentiny/vue-design-${tinyTheme}]·=
(prettier/prettier)
[error] 89-89: Replace ]·= with ·
(prettier/prettier)
🔇 Additional comments (1)
examples/sites/playground/App.vue (1)
307-313: LGTM! Version selection implementation looks good
The tiny-select component correctly:
- Disables version selection in preview mode
- Shows notification about version limitations
- Handles version changes appropriately
| const getVersion = () => { | ||
| if (isPreview) { | ||
| return versions[0] | ||
| } | ||
| if (versions.includes(localStorage.getItem(VERSION))) { | ||
| localStorage.getItem(VERSION) | ||
| } | ||
| return versions[0] | ||
| } |
There was a problem hiding this comment.
Fix logical error in getVersion function
The function has a bug in the conditional block that checks localStorage value. The return statement is missing, causing the function to always return versions[0].
Apply this diff to fix the logic:
const getVersion = () => {
if (isPreview) {
return versions[0]
}
- if (versions.includes(localStorage.getItem(VERSION))) {
- localStorage.getItem(VERSION)
+ const storedVersion = localStorage.getItem(VERSION)
+ if (versions.includes(storedVersion)) {
+ return storedVersion
}
return versions[0]
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const getVersion = () => { | |
| if (isPreview) { | |
| return versions[0] | |
| } | |
| if (versions.includes(localStorage.getItem(VERSION))) { | |
| localStorage.getItem(VERSION) | |
| } | |
| return versions[0] | |
| } | |
| const getVersion = () => { | |
| if (isPreview) { | |
| return versions[0] | |
| } | |
| const storedVersion = localStorage.getItem(VERSION) | |
| if (versions.includes(storedVersion)) { | |
| return storedVersion | |
| } | |
| return versions[0] | |
| } |
| imports[ | ||
| `@opentiny/vue-design-${tinyTheme}` | ||
| ] = `${cdnHost}/@opentiny/vue-design-${tinyTheme}${versionDelimiter}${version}/${fileDelimiter}index.js` |
There was a problem hiding this comment.
Fix template literal formatting
The current formatting of the imports object key causes ESLint errors.
Apply this diff to fix the formatting:
- imports[
- `@opentiny/vue-design-${tinyTheme}`
- ] = `${cdnHost}/@opentiny/vue-design-${tinyTheme}${versionDelimiter}${version}/${fileDelimiter}index.js`
+ imports[`@opentiny/vue-design-${tinyTheme}`] = `${cdnHost}/@opentiny/vue-design-${tinyTheme}${versionDelimiter}${version}/${fileDelimiter}index.js`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| imports[ | |
| `@opentiny/vue-design-${tinyTheme}` | |
| ] = `${cdnHost}/@opentiny/vue-design-${tinyTheme}${versionDelimiter}${version}/${fileDelimiter}index.js` | |
| imports[`@opentiny/vue-design-${tinyTheme}`] = `${cdnHost}/@opentiny/vue-design-${tinyTheme}${versionDelimiter}${version}/${fileDelimiter}index.js` |
🧰 Tools
🪛 eslint
[error] 87-88: Replace ⏎······@opentiny/vue-design-${tinyTheme}with@opentiny/vue-design-${tinyTheme}]·=
(prettier/prettier)
[error] 89-89: Replace ]·= with ·
(prettier/prettier)
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit