fix(steps): After the global style is changed, the UI screenshots of steps and timeline are incorrect. #79
Conversation
WalkthroughThe changes introduce a new test case in the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
tests/steps/xdesign.spec.ts (1)
20-26: LGTM! Consider minor adjustment for consistency.The new test case for '条形和高级向导型--UI截图' (Bar and Advanced Wizard Type--UI Screenshot) is well-structured and follows the pattern of existing test cases. It correctly handles page errors, navigates to the appropriate URL, checks viewport visibility, and captures a screenshot.
For consistency with other test cases, consider using '.pc-demo' instead of '.pc-demo-container' in the locator:
- const demo = page.locator('#advanced-steps .pc-demo-container') + const demo = page.locator('#advanced-steps .pc-demo')This change would align the new test case more closely with the existing ones, unless there's a specific reason for using '.pc-demo-container' in this case.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (8)
tests/steps/xdesign.spec.ts-snapshots/advanced-chromium-win32.pngis excluded by!**/*.pngtests/steps/xdesign.spec.ts-snapshots/line-dot-chromium-win32.pngis excluded by!**/*.pngtests/steps/xdesign.spec.ts-snapshots/line-horizontal-chromium-win32.pngis excluded by!**/*.pngtests/steps/xdesign.spec.ts-snapshots/size-chromium-win32.pngis excluded by!**/*.pngtests/steps/xdesign.spec.ts-snapshots/slot-item-footer-chromium-win32.pngis excluded by!**/*.pngtests/steps/xdesign.spec.ts-snapshots/slot-item-footer-hover-chromium-win32.pngis excluded by!**/*.pngtests/time-line/xdesign.spec.ts-snapshots/shape-chromium-win32.pngis excluded by!**/*.pngtests/time-line/xdesign.spec.ts-snapshots/status-chromium-win32.pngis excluded by!**/*.png
📒 Files selected for processing (2)
- tests/steps/xdesign.spec.ts (1 hunks)
- tests/time-line/xdesign.spec.ts (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
tests/time-line/xdesign.spec.ts (1)
15-15: LGTM! Consider verifying the test stability.The change to the locator makes it more specific, which should improve the precision of the test. This aligns well with the PR objective of fixing UI screenshots after global style changes.
To ensure this change doesn't introduce any instability, please run the following verification:
This script will search for the new locator structure in the HTML and Vue files. If it returns results, it confirms that the new locator exists in the HTML structure. If it doesn't return any results, you may want to double-check the HTML structure to ensure the new locator is correct.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit