Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction fee tests #2318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add transaction fee tests #2318

wants to merge 2 commits into from

Conversation

gztensor
Copy link
Contributor

Description of the Change

Modified e2e tests to check that

  • Non-zero transaction fee is applied for balance transfers
  • No transaction fee is applied for add_stake extrinsic

Quantitative Performance Benefits

Not relevant. We don't have a template for adding tests.

Possible Drawbacks

If later we decide to lower transaction fees for balance transfers (e.g. to high TAO price), we will have to maintain this test.

Verification Process

Run:

LOCALNET_SH_PATH=<---=== replace with your path to subtensor repository===--- >/subtensor/scripts/localnet.sh pytest ./tests/e2e_tests/subcommands/wallet/test_transfer.py

LOCALNET_SH_PATH=<---=== replace with your path to subtensor repository===--- >/subtensor/scripts/localnet.sh pytest ./tests/e2e_tests/subcommands/stake/test_stake_add_remove.py

Applicable Issues

https://github.com/orgs/opentensor/projects/19/views/7?pane=issue&itemId=80965602

Release Notes

This is subtensor e2e test, no release notes should be added for BitTensor.

open-junius
open-junius previously approved these changes Sep 25, 2024
Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls resolve the conflicts, then I gonna approve this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants