Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a wallet sign command #2201

Open
wants to merge 48 commits into
base: staging
Choose a base branch
from
Open

feat: add a wallet sign command #2201

wants to merge 48 commits into from

Conversation

edpoptart
Copy link 

Executes the ``sign`` command to sign a message with the provided wallet or wallet hotkey.

This command signs a message using the provided wallet.

Usage:
    The command generates a signature for a given message using the provided wallet

Optional arguments:
    --wallet.hotkey: A hotkey to use to sign the message instead of the wallet coldkey

Example usage::

    btcli wallet sign --wallet.name default --message '{"something": "here", "timestamp": 1719908486}'
    btcli wallet sign --wallet.name default --wallet.name hotkey --message '{"something": "here", "timestamp": 1719908486}'

Note:
    When using `btcli`, `w` is used interchangeably with `wallet`. You may use either based on your preference for brevity or clarity.
    This command is essential for users to easily prove their ownership over a coldkey or a hotkey.

roman-opentensor and others added 13 commits July 17, 2024 10:55
@roman-opentensor
Remove unused AccountId from ChainDataType
7d3cb26
@roman-opentensor
Update decode_hex_identity_dict function in commands utils.
c44ac68
@roman-opentensor
Update DelegatesDetails class and get_delegates_details
9118c00
@roman-opentensor
Add get_delegate_identities method to Subtensor class
6b9cdb3
@roman-opentensor
Update bittensor.commands.utils.get_delegates_details usage across …
ef9a8c5 
…the bittensor.
@roman-opentensor
ruff
7058bfb
@roman-opentensor
Add test for bittensor.utils.wallet_utils.decode_hex_identity_dict
0f9b6f3
@roman-opentensor
Add test for bittensor.commands.utils.get_delegates_details
5eef3ad
@roman-opentensor
Add test for bittensor.subtensor.Subtensor.get_delegate_identities
94532b8
@roman-opentensor
Merge branch 'staging' into feature/roman/migrate-delegate-info-to-on…
0219296 
…chain-indentities
@roman-opentensor
Merge branch 'staging' into feature/roman/migrate-delegate-info-to-on…
3f27b8e 
…chain-indentities
@roman-opentensor
Merge branch 'staging' into feature/roman/migrate-delegate-info-to-on…
c232b5a 
…chain-indentities
@roman-opentensor
Merge branch 'staging' into feature/roman/migrate-delegate-info-to-on…
1208e88 
…chain-indentities
@edpoptart edpoptart changed the title Add a wallet sign command using a keypair feat: add a wallet sign command using a keypair Aug 2, 2024
@edpoptart edpoptart force-pushed the feat/kbr/wallet-sign-command branch 3 times, most recently from 1ad6fbc to 7a2d343 Compare August 2, 2024 21:41
@edpoptart edpoptart changed the title feat: add a wallet sign command using a keypair feat: add a wallet sign command Aug 5, 2024
@edpoptart edpoptart force-pushed the feat/kbr/wallet-sign-command branch from 7a2d343 to c7cedf6 Compare August 6, 2024 19:23
@gus-opentensor gus-opentensor added the In Review Cortex Team Members Reviewing label Aug 7, 2024
@edpoptart edpoptart force-pushed the feat/kbr/wallet-sign-command branch from c7cedf6 to 72fd7ed Compare August 7, 2024 13:44
@edpoptart edpoptart force-pushed the feat/kbr/wallet-sign-command branch from 72fd7ed to 9289213 Compare August 7, 2024 16:09
@edpoptart edpoptart force-pushed the feat/kbr/wallet-sign-command branch 3 times, most recently from c7fe4e6 to ff87923 Compare August 8, 2024 16:01
@alex-drocks
Copy link

Lgtm

IvanAnishchuk
IvanAnishchuk approved these changes Sep 2, 2024
View reviewed changes
Copy link

@IvanAnishchuk IvanAnishchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think this feature is important and standard for most Crypto ecosystems. There's interest from several subnet operators and validators. Can we please get this rolling?

Is there anything anybody can do to help merge this quickly?

@ibraheem-opentensor
Merge branch 'staging' into fix/metagraph-load-and-assertions
f7345a6
@ibraheem-opentensor
Merge pull request opentensor#2235 from opentensor/fix/metagraph-load…
d438b0f 
…-and-assertions

Applies metagraph fix and assertions
@roman-opentensor
Add reconnection logic + tests
6a7b2ca
@edpoptart
Merge branch 'staging' into feat/kbr/wallet-sign-command
af4e3bf
@roman-opentensor
Merge pull request opentensor#2280 from opentensor/feat/roman/add-sub…
5fcdcfd 
…tensor-reconnection-logic

Add reconnection logic + tests
@edpoptart
Merge branch 'staging' into feat/kbr/wallet-sign-command
d4239ee
@garrett-opentensor
removed exit sys call for ConnectionRefusedError in _get_substrate (o…
c7b4739 
…pentensor#2287)

* removed exit sys call for ConnectionRefusedError in _get_substrate

* removed unnecessary sys import

* ruff format fix
@ibraheem-opentensor
Merge branch 'staging' into backmerge/release-7.4.0
7a5fc76
@ibraheem-opentensor
Merge pull request opentensor#2302 from opentensor/backmerge/release-…
7d6bcad 
…7.4.0

Backmerge/release 7.4.0
@edpoptart
Merge branch 'staging' into feat/kbr/wallet-sign-command
9c6837d
@roman-opentensor
Merge remote-tracking branch 'origin/staging' into feature/roman/migr…
5325fb4 
…ate-delegate-info-to-onchain-indentities

# Conflicts:
#	bittensor/subtensor.py
#	tests/unit_tests/test_subtensor.py
@roman-opentensor
fix
377e913
@roman-opentensor
ruff
55a2a25
@roman-opentensor
Merge pull request opentensor#2146 from opentensor/feature/roman/migr…
52f0df5 
…ate-delegate-info-to-onchain-indentities

`Migrate Delegate Info to onchain Indentities` implimentation.
@edpoptart
Merge branch 'staging' into feat/kbr/wallet-sign-command
de83cb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild left review comments

@gus-opentensor gus-opentensor gus-opentensor left review comments

@IvanAnishchuk IvanAnishchuk IvanAnishchuk approved these changes

@Rapiiidooo Rapiiidooo Rapiiidooo approved these changes

@alex-drocks alex-drocks alex-drocks approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
In Review Cortex Team Members Reviewing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@edpoptart @gus-opentensor @alex-drocks @IvanAnishchuk @Rapiiidooo @camfairchild @roman-opentensor @ibraheem-opentensor @opendansor @garrett-opentensor