Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault: Detailed errors for dynamic users #113

Merged
merged 7 commits into from
Oct 27, 2022
Merged

Vault: Detailed errors for dynamic users #113

merged 7 commits into from
Oct 27, 2022

Conversation

artem-lifshits
Copy link
Member

Detailed errors for path_roles.go.
Introduced a new vars/error.go list of custom errors.
Refers to: #111

@artem-lifshits artem-lifshits self-assigned this Oct 27, 2022
@artem-lifshits
Copy link
Member Author

artem@Artems-MacBook-Pro vault-plugin-secrets-openstack % make functional
Running acceptance tests...
=== RUN TestPlugin
=== RUN TestPlugin/TestCloudLifecycle
=== RUN TestPlugin/TestCloudLifecycle/WriteCloud
=== RUN TestPlugin/TestCloudLifecycle/ReadCloud
=== RUN TestPlugin/TestCloudLifecycle/ListClouds
=== RUN TestPlugin/TestCloudLifecycle/ListClouds/method-LIST
=== PAUSE TestPlugin/TestCloudLifecycle/ListClouds/method-LIST
=== RUN TestPlugin/TestCloudLifecycle/ListClouds/method-GET
=== PAUSE TestPlugin/TestCloudLifecycle/ListClouds/method-GET
=== CONT TestPlugin/TestCloudLifecycle/ListClouds/method-LIST
=== CONT TestPlugin/TestCloudLifecycle/ListClouds/method-GET
=== RUN TestPlugin/TestCloudLifecycle/DeleteCloud
=== RUN TestPlugin/TestCredsLifecycle
=== RUN TestPlugin/TestCredsLifecycle/root_token
=== RUN TestPlugin/TestCredsLifecycle/user_token
=== RUN TestPlugin/TestCredsLifecycle/user_password
=== RUN TestPlugin/TestInfo
info_test.go:42:
Error Trace: info_test.go:42
Error: Should NOT be empty, but was &{ }
Test: TestPlugin/TestInfo
=== RUN TestPlugin/TestRoleLifecycle
=== RUN TestPlugin/TestRoleLifecycle/WriteRole
=== RUN TestPlugin/TestRoleLifecycle/ReadRole
=== RUN TestPlugin/TestRoleLifecycle/ListRoles
=== RUN TestPlugin/TestRoleLifecycle/ListRoles/method-LIST
=== PAUSE TestPlugin/TestRoleLifecycle/ListRoles/method-LIST
=== RUN TestPlugin/TestRoleLifecycle/ListRoles/method-GET
=== PAUSE TestPlugin/TestRoleLifecycle/ListRoles/method-GET
=== CONT TestPlugin/TestRoleLifecycle/ListRoles/method-LIST
=== CONT TestPlugin/TestRoleLifecycle/ListRoles/method-GET
=== RUN TestPlugin/TestRoleLifecycle/DeleteRole
=== RUN TestPlugin/TestRootRotate
rotate_test.go:65: Cloud with name default1 was created
rotate_test.go:68: Cloud with name txgl was created
plugin_test.go:337: Cloud with name txgl has been removed
plugin_test.go:337: Cloud with name default1 has been removed
=== RUN TestPlugin/TestStaticCredsLifecycle
=== RUN TestPlugin/TestStaticCredsLifecycle/user_token_project_name
=== RUN TestPlugin/TestStaticCredsLifecycle/user_password
=== RUN TestPlugin/TestStaticCredsLifecycle/user_token_project_id
=== RUN TestPlugin/TestStaticRoleLifecycle
=== RUN TestPlugin/TestStaticRoleLifecycle/WriteRole
=== RUN TestPlugin/TestStaticRoleLifecycle/ReadRole
=== RUN TestPlugin/TestStaticRoleLifecycle/ListRoles
=== RUN TestPlugin/TestStaticRoleLifecycle/ListRoles/method-LIST
=== PAUSE TestPlugin/TestStaticRoleLifecycle/ListRoles/method-LIST
=== RUN TestPlugin/TestStaticRoleLifecycle/ListRoles/method-GET
=== PAUSE TestPlugin/TestStaticRoleLifecycle/ListRoles/method-GET
=== CONT TestPlugin/TestStaticRoleLifecycle/ListRoles/method-LIST
=== CONT TestPlugin/TestStaticRoleLifecycle/ListRoles/method-GET
=== RUN TestPlugin/TestStaticRoleLifecycle/DeleteRole
--- FAIL: TestPlugin (27.88s)
--- PASS: TestPlugin/TestCloudLifecycle (0.09s)
--- PASS: TestPlugin/TestCloudLifecycle/WriteCloud (0.08s)
--- PASS: TestPlugin/TestCloudLifecycle/ReadCloud (0.00s)
--- PASS: TestPlugin/TestCloudLifecycle/ListClouds (0.00s)
--- PASS: TestPlugin/TestCloudLifecycle/ListClouds/method-GET (0.00s)
--- PASS: TestPlugin/TestCloudLifecycle/ListClouds/method-LIST (0.00s)
--- PASS: TestPlugin/TestCloudLifecycle/DeleteCloud (0.00s)
--- PASS: TestPlugin/TestCredsLifecycle (6.19s)
--- PASS: TestPlugin/TestCredsLifecycle/root_token (1.92s)
--- PASS: TestPlugin/TestCredsLifecycle/user_token (2.41s)
--- PASS: TestPlugin/TestCredsLifecycle/user_password (1.00s)
--- FAIL: TestPlugin/TestInfo (0.00s)
--- PASS: TestPlugin/TestRoleLifecycle (0.62s)
--- PASS: TestPlugin/TestRoleLifecycle/WriteRole (0.60s)
--- PASS: TestPlugin/TestRoleLifecycle/ReadRole (0.00s)
--- PASS: TestPlugin/TestRoleLifecycle/ListRoles (0.00s)
--- PASS: TestPlugin/TestRoleLifecycle/ListRoles/method-GET (0.00s)
--- PASS: TestPlugin/TestRoleLifecycle/ListRoles/method-LIST (0.00s)
--- PASS: TestPlugin/TestRoleLifecycle/DeleteRole (0.00s)
--- PASS: TestPlugin/TestRootRotate (5.05s)
--- PASS: TestPlugin/TestStaticCredsLifecycle (12.91s)
--- PASS: TestPlugin/TestStaticCredsLifecycle/user_token_project_name (4.22s)
--- PASS: TestPlugin/TestStaticCredsLifecycle/user_password (3.43s)
--- PASS: TestPlugin/TestStaticCredsLifecycle/user_token_project_id (4.11s)
--- PASS: TestPlugin/TestStaticRoleLifecycle (2.86s)
--- PASS: TestPlugin/TestStaticRoleLifecycle/WriteRole (1.02s)
--- PASS: TestPlugin/TestStaticRoleLifecycle/ReadRole (0.00s)
--- PASS: TestPlugin/TestStaticRoleLifecycle/ListRoles (0.00s)
--- PASS: TestPlugin/TestStaticRoleLifecycle/ListRoles/method-LIST (0.00s)
--- PASS: TestPlugin/TestStaticRoleLifecycle/ListRoles/method-GET (0.00s)
--- PASS: TestPlugin/TestStaticRoleLifecycle/DeleteRole (0.00s)
FAIL
FAIL github.com/opentelekomcloud/vault-plugin-secrets-openstack/acceptance 31.017s
FAIL
make: *** [functional] Error 1

@artem-lifshits artem-lifshits added the enhancement New feature or request label Oct 27, 2022
openstack/path_role.go Show resolved Hide resolved
openstack/path_role.go Show resolved Hide resolved
openstack/path_role.go Show resolved Hide resolved
@artem-lifshits artem-lifshits added the gate Merge PR label Oct 27, 2022
@otc-zuul
Copy link

otc-zuul bot commented Oct 27, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/0dee1a626bb3450499ed1034a9e1ebc1

✔️ build-sphinx-docs SUCCESS in 3m 28s
✔️ otc-golangci-lint SUCCESS in 1m 58s
✔️ golang-make-vet SUCCESS in 1m 54s
✔️ golang-make-test SUCCESS in 2m 00s
✔️ goreleaser-build SUCCESS in 4m 30s

@otc-zuul otc-zuul bot merged commit 7a0f85b into main Oct 27, 2022
@otc-zuul otc-zuul bot deleted the path_roles_errors branch October 27, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants