Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in provider are meaningless #111

Closed
lego963 opened this issue Oct 18, 2022 · 0 comments
Closed

Errors in provider are meaningless #111

lego963 opened this issue Oct 18, 2022 · 0 comments
Assignees
@artem-lifshits
Labels
enhancement New feature or request

Comments

@lego963
Copy link
Contributor

lego963 commented Oct 18, 2022 •
edited
Loading

Description

Vault sdk supports CodedErrors https://github.com/hashicorp/vault/blob/main/sdk/logical/error.go
We need to use it because current 500 are meaningless

Plus, we need to log full error instead of Authentication failed
Reference: #109
@lego963 lego963 added the enhancement New feature or request label Oct 18, 2022
@artem-lifshits artem-lifshits self-assigned this Oct 19, 2022
@artem-lifshits artem-lifshits mentioned this issue Oct 27, 2022
Merged
otc-zuul bot pushed a commit that referenced this issue Oct 27, 2022
@artem-lifshits
Vault: Detailed errors for dynamic users (#113)
7a0f85b 
Vault: Detailed errors for dynamic users

Detailed errors for path_roles.go.
Introduced a new vars/error.go list of custom errors.
Refers to: #111

Reviewed-by: Anton Sidelnikov
Reviewed-by: Artem Lifshits
Reviewed-by: Aloento
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artem-lifshits artem-lifshits

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lego963 @artem-lifshits