Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] VPCEP resources and data-sources #2762

Merged
merged 4 commits into from
Dec 12, 2024
Merged

[Refactor] VPCEP resources and data-sources #2762

merged 4 commits into from
Dec 12, 2024

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Dec 12, 2024 •
edited
Loading

Summary of the Pull Request

Refactoring old resources

PR Checklist

  • Refers to: #xxx
  • Tests added/passed.
  • Documentation updated.
  • Schema updated.
  • Release notes added.

Acceptance Steps Performed

=== RUN   TestVPCEPService_basic
=== PAUSE TestVPCEPService_basic
=== CONT  TestVPCEPService_basic
--- PASS: TestVPCEPService_basic (94.16s)
PASS

Process finished with the exit code 0

=== RUN   TestVPCEndpoint_basic
=== PAUSE TestVPCEndpoint_basic
=== CONT  TestVPCEndpoint_basic
--- PASS: TestVPCEndpoint_basic (75.05s)
PASS

Process finished with the exit code 0

=== RUN   TestDataSourceVPCEPPublicService
=== PAUSE TestDataSourceVPCEPPublicService
=== CONT  TestDataSourceVPCEPPublicService
--- PASS: TestDataSourceVPCEPPublicService (21.19s)
PASS

Process finished with the exit code 0

=== RUN   TestDataSourceVPCEPService
=== PAUSE TestDataSourceVPCEPService
=== CONT  TestDataSourceVPCEPService
--- PASS: TestDataSourceVPCEPService (84.09s)
PASS

Process finished with the exit code 0

@anton-sidelnikov anton-sidelnikov self-assigned this Dec 12, 2024
Aloento
Aloento previously approved these changes Dec 12, 2024
View reviewed changes
artem-lifshits
artem-lifshits previously approved these changes Dec 12, 2024
View reviewed changes
artem-lifshits
artem-lifshits reviewed Dec 12, 2024
View reviewed changes
go.sum
@@ -158,6 +158,8 @@ github.com/oklog/run v1.0.0 h1:Ru7dDtJNOyC66gQ5dQmaCa0qIsAUFY3sFpK1Xk8igrw=
github.com/oklog/run v1.0.0/go.mod h1:dlhp/R75TPv97u0XWUtDeV/lRKWPKSdTuV0TZvrmrQA=
github.com/opentelekomcloud/gophertelekomcloud v0.9.4-0.20241210160040-3b0fb9159f71 h1:K+DlJ0svuSiXfuaN+M2pG1LZvgtnq7uMjCLpCeTMBJQ=
github.com/opentelekomcloud/gophertelekomcloud v0.9.4-0.20241210160040-3b0fb9159f71/go.mod h1:M1F6OfSRZRzAmAFKQqSLClX952at5hx5rHe4UTEykgg=
github.com/opentelekomcloud/gophertelekomcloud v0.9.4-0.20241211090426-8e0297aa1379 h1:E4Oc5QRAPwLanhJv0igiuVPQ5j1+4WYzck8EVNV+u/A=
github.com/opentelekomcloud/gophertelekomcloud v0.9.4-0.20241211090426-8e0297aa1379/go.mod h1:M1F6OfSRZRzAmAFKQqSLClX952at5hx5rHe4UTEykgg=
Copy link
Member

@artem-lifshits artem-lifshits Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go mod tidy, gophertelekomcloud modules are doubled

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@artem-lifshits artem-lifshits self-requested a review December 12, 2024 11:35
@anton-sidelnikov anton-sidelnikov added the gate Merge PR label Dec 12, 2024
@otc-zuul otc-zuul
Copy link

otc-zuul bot commented Dec 12, 2024

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/b3731aad84254bb69be0b414801dfaa5

✔️ build-otc-releasenotes SUCCESS in 4m 14s
✔️ noop SUCCESS in 0s
✔️ otc-golangci-lint SUCCESS in 3m 11s
✔️ golang-make-test SUCCESS in 3m 59s
✔️ golang-make-vet SUCCESS in 3m 04s
✔️ tflint SUCCESS in 1m 47s
✔️ goreleaser-build SUCCESS in 8m 32s

@otc-zuul otc-zuul bot merged commit 3ecca09 into devel Dec 12, 2024
6 checks passed
@otc-zuul otc-zuul bot deleted the vpcep-update branch December 12, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muneeb-jan muneeb-jan muneeb-jan approved these changes

@artem-lifshits artem-lifshits artem-lifshits approved these changes

@Aloento Aloento Aloento left review comments

@vladimirvshivkov vladimirvshivkov Awaiting requested review from vladimirvshivkov

Assignees

@anton-sidelnikov anton-sidelnikov

Labels
dependencies documentation gate Merge PR refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anton-sidelnikov @Aloento @artem-lifshits @muneeb-jan