Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6 - Removed bitmaps and replaced with vector files. #8

Merged
merged 4 commits into from
Oct 30, 2014

Conversation

andygunn
Copy link

Lots and lots of files changed in Commotion / Basic-Elements. Per issue #6 .

@critzo @georgiamoon - Can you please check this and make sure everything looks okay!

Andy Gunn added 3 commits September 10, 2014 15:13
…r each. Modified hardware to consumables and removed electroncs that were previously there.
…ngs, towers, and wireless signals should be good.
@georgiamoon
Copy link
Member

@critzo can we run this locally to see it like we can with the commotion site? what do we need to do to get jekyll running locally for this repo? Just wanted to explore the files that way!

@georgiamoon
Copy link
Member

also, one question @andygunn and I had was around how to handle licenses for all the graphics, and specifically for noun project stuff that's also in here. if @critzo or @commandline has thoughts, we should discuss!

I was thinking that since the noun project files have the metadata about them and their licenses in the files, those should be fine, and that maybe we just need to include a note on the main page that some of the graphics are creative commons from the noun project? Let's talk about it when people have a minute - no hurry, just wanted to record thoughts here.

@critzo
Copy link

critzo commented Sep 17, 2014

@georgiamoon Yes, you should be able to run this locally via the same process as the Commotion site.

@andygunn
Copy link
Author

@critzo - I get an error:

Configuration file: /home/andygunn/project-graphics/_config.yml
/usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require': cannot load such file -- exifr (LoadError)
    from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /home/andygunn/project-graphics/_plugins/exif_tag.rb:7:in `<top (required)>'
    from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /usr/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/plugin_manager.rb:58:in `block (2 levels) in require_plugin_files'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/plugin_manager.rb:57:in `each'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/plugin_manager.rb:57:in `block in require_plugin_files'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/plugin_manager.rb:56:in `each'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/plugin_manager.rb:56:in `require_plugin_files'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/plugin_manager.rb:18:in `conscientious_require'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/site.rb:71:in `setup'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/site.rb:33:in `initialize'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/commands/build.rb:28:in `new'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/commands/build.rb:28:in `process'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/lib/jekyll/commands/serve.rb:24:in `block (2 levels) in init_with_program'
    from /var/lib/gems/1.9.1/gems/mercenary-0.3.4/lib/mercenary/command.rb:220:in `call'
    from /var/lib/gems/1.9.1/gems/mercenary-0.3.4/lib/mercenary/command.rb:220:in `block in execute'
    from /var/lib/gems/1.9.1/gems/mercenary-0.3.4/lib/mercenary/command.rb:220:in `each'
    from /var/lib/gems/1.9.1/gems/mercenary-0.3.4/lib/mercenary/command.rb:220:in `execute'
    from /var/lib/gems/1.9.1/gems/mercenary-0.3.4/lib/mercenary/program.rb:35:in `go'
    from /var/lib/gems/1.9.1/gems/mercenary-0.3.4/lib/mercenary.rb:22:in `program'
    from /var/lib/gems/1.9.1/gems/jekyll-2.1.1/bin/jekyll:18:in `<top (required)>'
    from /usr/local/bin/jekyll:23:in `load'
    from /usr/local/bin/jekyll:23:in `<main>'

@critzo
Copy link

critzo commented Sep 17, 2014

@andygunn @georgiamoon This has to do with one of the plugins, exif_tag.rb, which I was experimenting with to use image file metadata to do tagging or provide other information. Try creating a branch, moving that file out of plugins/ folder and then try rebuilding

@andygunn
Copy link
Author

@critzo - That did it. Everything builds just fine, thanks!

@georgiamoon
Copy link
Member

One thing related to this PR: in the Commotion Folder - Move the people PNGs, to Commotion > Basic > People as SVGs

@andygunn
Copy link
Author

@georgiamoon - Last push resolved the extra people graphics. Now in the Commotion -> Basic -> People directory. All cleaned up.

Ready to merge.

@andygunn
Copy link
Author

@critzo @georgiamoon - Can someone merge this? It has been languishing for over a month...

georgiamoon added a commit that referenced this pull request Oct 30, 2014
Issue 6 - Removed bitmaps and replaced with vector files.
@georgiamoon georgiamoon merged commit cd191c5 into master Oct 30, 2014
@georgiamoon
Copy link
Member

done!

On Thu, Oct 30, 2014 at 11:44 AM, Andy Gunn [email protected]
wrote:

@critzo https://github.com/critzo @georgiamoon
https://github.com/georgiamoon - Can someone merge this? It has been
languishing for over a month...


Reply to this email directly or view it on GitHub
#8 (comment)
.

Georgia Bullen
Senior Data Analyst
Open Technology Institute http://newamerica.org/oti/ @ New America
http://newamerica.org
@georgiamoon http://twitter.com/georgiamoon

@andygunn
Copy link
Author

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Awesome, thanks!

On 10/30/2014 11:48 AM, georgia bullen wrote:

done!

On Thu, Oct 30, 2014 at 11:44 AM, Andy Gunn
[email protected] wrote:

@critzo https://github.com/critzo @georgiamoon
https://github.com/georgiamoon - Can someone merge this? It has
been languishing for over a month...

— Reply to this email directly or view it on GitHub

#8 (comment)

.

-- Georgia Bullen Senior Data Analyst Open Technology Institute
http://newamerica.org/oti/ @ New America http://newamerica.org
@georgiamoon http://twitter.com/georgiamoon

— Reply to this email directly or view it on GitHub
#8 (comment).


Andy Gunn, Field Engineer
Open Technology Institute, New America Foundation
[email protected] | 202-596-3484

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUUmFTAAoJEO7c3Fzx1WU81BkIAKM4J1b0n860n7iTOC9ZDMUh
iVyHAq9qpMmn5aa00zlp026nMYP1nCZ3SAYVwVnez5zpD1svlfRvhFA3HUoMUHc3
Mieo3xtGSaqL7LL+VxZhX+7+8FuZ8XBtnZfJqjQSN2RtYVVGYse7yq67zm1A2qQH
TRvrpqeJY1oaXZeRxqFT8KKcyTnbcsbBr0ribeHphs+TYRdtRNVBimzdA5CKQPNj
MgFKMvRV11ZP5bt8nkxxgW769N3raca8REWT2aTebeciWzsoyWc75VxXuRHbxWQI
68XHERTSngDHMPOLITKeYE0FqNYoxvVLXn1FDzqw9G7ZbVO3mYI6kYjv24vTr9Q=
=NLzX
-----END PGP SIGNATURE-----

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants