Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authz): Return deny on GetDecision if resource attribute lookup returns not found #962

Merged
merged 4 commits into from
Jun 26, 2024
Merged

fix(authz): Return deny on GetDecision if resource attribute lookup returns not found #962

merged 4 commits into from
Jun 26, 2024

Conversation

elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Jun 11, 2024 •
edited
Loading

resolves #950

@elizabethhealy elizabethhealy marked this pull request as ready for review June 11, 2024 14:07
@elizabethhealy elizabethhealy requested a review from a team as a code owner June 11, 2024 14:07
dmihalcik-virtru
dmihalcik-virtru previously approved these changes Jun 11, 2024
View reviewed changes
service/authorization/authorization.go Outdated Show resolved Hide resolved
@elizabethhealy elizabethhealy added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 7dea640 Jun 26, 2024
17 checks passed
@elizabethhealy elizabethhealy deleted the decision-deny-attr-dne branch June 26, 2024 13:58
@opentdf-automation opentdf-automation bot mentioned this pull request Jun 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 2, 2024
@opentdf-automation
chore(main): release service 0.4.8 (#1028)
e3318e1 
🤖 I have created a release *beep* *boop*
---


##
[0.4.8](service/v0.4.7...service/v0.4.8)
(2024-07-02)


### Features

* **policy:** add index to fqn column in attribute_fqns table
([#1035](#1035))
([1b0cf38](1b0cf38)),
closes [#1053](#1053)
* **policy:** add unsafe attribute RPC db connectivity
([#1022](#1022))
([fbc02f3](fbc02f3))
* **policy:** attribute values unsafe actions db connectivity
([#1030](#1030))
([4a30426](4a30426))
* **policy:** register unsafe service in platform
([#1066](#1066))
([b7796cd](b7796cd))


### Bug Fixes

* **authz:** Return deny on GetDecision if resource attribute lookup
returns not found
([#962](#962))
([7dea640](7dea640))
* **core:** Autobump service
([#1072](#1072))
([409df67](409df67))
* **core:** Autobump service
([#1079](#1079))
([10138d2](10138d2))
* **core:** Autobump service
([#1084](#1084))
([968883e](968883e))
* **core:** database clients pooling improvements
([#1047](#1047))
([8193cec](8193cec))
* **core:** swap out internal issuer for external issuer endpoint
([#1027](#1027))
([c3828d0](c3828d0))
* **core:** update casbin policy to allow authorization service
([#1041](#1041))
([552e970](552e970))
* **policy:** provide ns and val fqns back on list attributes response
([#1050](#1050))
([1be04f6](1be04f6)),
closes [#1052](#1052)
* **policy:** rename unsafe rpcs for aligned casbin action determination
([#1067](#1067))
([7861e4a](7861e4a))
* **policy:** run migrations on db only once for all policy services
([#1040](#1040))
([db4f06f](db4f06f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
jakedoublev pushed a commit that referenced this pull request Jul 7, 2024
@opentdf-automation @jakedoublev
chore(main): release service 0.4.8 (#1028)
dfffc7a 
🤖 I have created a release *beep* *boop*
---


##
[0.4.8](service/v0.4.7...service/v0.4.8)
(2024-07-02)


### Features

* **policy:** add index to fqn column in attribute_fqns table
([#1035](#1035))
([1b0cf38](1b0cf38)),
closes [#1053](#1053)
* **policy:** add unsafe attribute RPC db connectivity
([#1022](#1022))
([fbc02f3](fbc02f3))
* **policy:** attribute values unsafe actions db connectivity
([#1030](#1030))
([4a30426](4a30426))
* **policy:** register unsafe service in platform
([#1066](#1066))
([b7796cd](b7796cd))


### Bug Fixes

* **authz:** Return deny on GetDecision if resource attribute lookup
returns not found
([#962](#962))
([7dea640](7dea640))
* **core:** Autobump service
([#1072](#1072))
([409df67](409df67))
* **core:** Autobump service
([#1079](#1079))
([10138d2](10138d2))
* **core:** Autobump service
([#1084](#1084))
([968883e](968883e))
* **core:** database clients pooling improvements
([#1047](#1047))
([8193cec](8193cec))
* **core:** swap out internal issuer for external issuer endpoint
([#1027](#1027))
([c3828d0](c3828d0))
* **core:** update casbin policy to allow authorization service
([#1041](#1041))
([552e970](552e970))
* **policy:** provide ns and val fqns back on list attributes response
([#1050](#1050))
([1be04f6](1be04f6)),
closes [#1052](#1052)
* **policy:** rename unsafe rpcs for aligned casbin action determination
([#1067](#1067))
([7861e4a](7861e4a))
* **policy:** run migrations on db only once for all policy services
([#1040](#1040))
([db4f06f](db4f06f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakedoublev jakedoublev jakedoublev left review comments

@patmantru patmantru patmantru approved these changes

@strantalis strantalis Awaiting requested review from strantalis

@dmihalcik-virtru dmihalcik-virtru Awaiting requested review from dmihalcik-virtru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

authz: Return DENY decision instead of throwing error when encountering attribute that doesn't exist
5 participants
@elizabethhealy @strantalis @dmihalcik-virtru @patmantru @jakedoublev