feat(authz): [DRAFT] Add temporal attribute to AccessPDP #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaundrae
changed the title
|
@Leaundrae thoughts on changing contains to between? fun fact -> moment/moment@90efd78 |
I'm good with using between. Its cleaner and |
davidbkirk
changed the title
davidbkirk
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
Leaundrae
commented
Sep 26, 2024
service/cmd/keycloak_data.yaml
Outdated
There was a problem hiding this comment.
Since no longer using the bootstrap keycloak, can revert these
Leaundrae
commented
Sep 26, 2024
Leaundrae
commented
Sep 26, 2024
service/internal/auth/casbin.go
Outdated
There was a problem hiding this comment.
could be useful later but remove for now to reduce footprint
Leaundrae
commented
Sep 26, 2024
service/internal/server/server.go
Outdated
There was a problem hiding this comment.
no longer need these logs can revert
Leaundrae
commented
Sep 26, 2024
| @@ -440,7 +441,12 @@ func makeScopeMap(scope *authorization.ResourceAttribute) map[string]bool { | |||
| } | |||
|
|
|||
| func (as *AuthorizationService) GetEntitlements(ctx context.Context, req *authorization.GetEntitlementsRequest) (*authorization.GetEntitlementsResponse, error) { | |||
| as.logger.DebugContext(ctx, "getting entitlements") | |||
| as.logger.DebugContext(ctx,"Preparing to retrieve entitlements") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.