-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): Only do a minor bump; #1534
base: fix/nanotdf-fix-function-signature
Are you sure you want to change the base?
chore(sdk): Only do a minor bump; #1534
Conversation
deprecate don't delete
This comment has been minimized.
This comment has been minimized.
Warning This pull request does not reference any issues. Please add a reference to an issue in the body of the pull request description. |
@dmihalcik-virtru this isn't great DX. If we don't want to use Here are some stories for encrypt:
Equally, here are some stories for decrypt:
|
yeah, we need to let CreateTDF take a Reader instead of a SeekableReader, too |
Also, additional thoughts/use cases:
|
I'll put together some thoughts about how best to design these APIs |
Sounds good. Do you think it's fair to push this issue back to todo to get better grooming so we can identify all the usecases we want to cover? |
deprecate don't delete