-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(policy): add unsafe service protos and unsafe service proto Go gencode #1003
Conversation
@jakedoublev I'm wondering if we want the client to return some value to verify they was to perform this destructive behavior. For instance if you want to delete you need to provide the id and the name. |
Then we can just pass the user's input from CLI or web directly to the server. No need for user clients to add that layer. |
That's a good idea @jrschumacher. I think the behavior that would guard against is a mistaken UUID being utilized to delete the policy object. Some other options would be:
Of those, I think 1 is too burdensome and 2 is awkward and clunky. Your suggestion is great to prevent a mistake and for consumer DX/UX downstream, and requiring the FQN instead of just the object name/value will require the user to know it, copy/paste, or type it in, which is good. |
I think The protos ensure gencode in each language and the HTTP path behind |
…dd validation for updated string fields when updating
🤖 I have created a release *beep* *boop* --- ## [0.2.4](protocol/go/v0.2.3...protocol/go/v0.2.4) (2024-06-18) ### Features * **core:** New cryptoProvider config ([#939](#939)) ([8150623](8150623)) * **policy:** add unsafe service protos and unsafe service proto Go gencode ([#1003](#1003)) ([55cc045](55cc045)) ### Bug Fixes * **core:** policy resource-mappings fix doc drift in proto comments ([#980](#980)) ([09ab763](09ab763)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.4.7](service/v0.4.6...service/v0.4.7) (2024-06-24) ### Features * add dev_mode flag ([#985](#985)) ([8da2436](8da2436)) * adds new trace log level ([#989](#989)) ([25f699e](25f699e)) * Audit GetDecisions ([#976](#976)) ([55bdfeb](55bdfeb)) * **authz:** Use flattened entity representations in subject mapping evaluation ([#1007](#1007)) ([b80443f](b80443f)) * **core:** add doublestar for public routes ([#998](#998)) ([1c70c16](1c70c16)) * **core:** New cryptoProvider config ([#939](#939)) ([8150623](8150623)) * **policy:** add unsafe service protos and unsafe service proto Go gencode ([#1003](#1003)) ([55cc045](55cc045)) * **policy:** policy unsafe namespace RPCs wired up to database ([#1018](#1018)) ([239d9fa](239d9fa)) * **policy:** service stubs and registration for unsafe service ([#1009](#1009)) ([9145491](9145491)) ### Bug Fixes * config loaded debug statement logs secrets ([#1010](#1010)) ([6f6a603](6f6a603)) * **core:** Autobump service ([#1025](#1025)) ([588827c](588827c)) * **core:** Fixes issue failing to find keys for kid-free kaos ([#982](#982)) ([f27d484](f27d484)) * **core:** policy resource-mappings fix doc drift in proto comments ([#980](#980)) ([09ab763](09ab763)) * **core:** Update to lib/fixtures 0.2.7 ([#1017](#1017)) ([dbae6ff](dbae6ff)) * **core:** Updates to protos 0.2.4 ([#1014](#1014)) ([43e11a3](43e11a3)) * **kas:** remove old logs ([#992](#992)) ([192ff6d](192ff6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
First PR related to #115