Refactor embed.js.erb with layers.yml #5571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmd-osm
reviewed
Jan 29, 2025
tomhughes
reviewed
Jan 29, 2025
app/assets/javascripts/embed.js.erb
Outdated
| new L.OSM.Mapnik(mapnikOptions).addTo(map); | ||
| } | ||
| const layers = <%= | ||
| (YAML.load_file(Rails.root.join("config/layers.yml")) |
There was a problem hiding this comment.
I don't believe the outer parentheses are needed here? I tried it in the rails console and I got the same JSON without them...
Also can we indent the ruby code by four spaces so it's a bit more readable? or does that trigger some lint issue?
There was a problem hiding this comment.
Sure, I tested it directly with puts, which didn't like the dangling to_json, but this isn't the case here.
Generated by 🚫 Danger |
added 2 commits
January 30, 2025 07:38
|
Ok I don't think I could've failed harder in squashing the previous commits 🫠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #5550 but with reading the layers.yml file instead of duplicating information