Skip to content

Commit

Permalink
Make danger labels use consisent capitalisation
Browse files Browse the repository at this point in the history
Existing labels are all lower case and avoid spaces.
  • Loading branch information
tomhughes committed Oct 26, 2024
1 parent c644e0f commit f6c2e43
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ pr_number = github.pr_json["number"]
# Report if number of changed lines is > 500
if git.lines_of_code > 500
warn("Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more?")
auto_label.set(pr_number, "Big PR", "FBCA04")
auto_label.set(pr_number, "big-pr", "FBCA04")
else
auto_label.remove("Big PR")
auto_label.remove("big-pr")
end

# Get list of translation files (except en.yml) which are modified
Expand All @@ -16,17 +16,17 @@ end

# Report if some translation file (except en.yml) is modified
if modified_yml_files.empty?
auto_label.remove("Inappropriate Translations")
auto_label.remove("inappropriate-translations")
else
modified_files_str = modified_yml_files.map { |file| "`#{file}`" }.join(", ")
warn("The following YAML files other than `en.yml` have been modified: #{modified_files_str}. Only `en.yml` is allowed to be changed. Translations are updated via Translatewiki, see CONTRIBUTING.md.")
auto_label.set(pr_number, "Inappropriate Translations", "B60205")
auto_label.set(pr_number, "inappropriate-translations", "B60205")
end

# Report if there are merge-commits in PR
if git.commits.any? { |c| c.parents.count > 1 }
warn("Merge commits are found in PR. Please rebase to get rid of the merge commits in this PR, see CONTRIBUTING.md.")
auto_label.set(pr_number, "Merge Commits", "D93F0B")
auto_label.set(pr_number, "merge-commits", "D93F0B")
else
auto_label.remove("Merge Commits")
auto_label.remove("merge-commits")
end

0 comments on commit f6c2e43

Please sign in to comment.