WA: fix bug where bill version notes are long repeated strings #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Passed Legislature" comes from the state, they call it "Bill as Passed Legislature". e.g. https://app.leg.wa.gov/billsummary/?BillNumber=1017&Year=2023&Initiative=false so I think that's probably ok. |
|
Good point, thanks Tim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting string repeats concatenated into bill version notes field, like
Second Substitute Substitute Substitute Substitute Substitute Second Substitute Joint Resolutionbecause the loop didn't reliably initialize a variable. Some bill versions failed to import because the notes got so long, which is how I noticed.A default of "Passed Legislature" is a little weird for passed bill versions ... but to fix we'd need to scrape each bill version page and hunt around for the right text. Which I don't think is really worth it but could be a good improvement in the future.