40 : Added keycloak configuration #1
Conversation
rehammuzzamil
changed the title
...g-boot-samples/hapi-fhir-spring-boot-sample-server-jersey/src/main/resources/application.yml
Outdated
Show resolved
Hide resolved
hapi-fhir-spring-boot/hapi-fhir-spring-boot-autoconfigure/src/main/resources/application.yml
Outdated
Show resolved
Hide resolved
...autoconfigure/src/main/java/ca/uhn/fhir/spring/boot/autoconfigure/FhirAutoConfiguration.java
Outdated
Show resolved
Hide resolved
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-deployable-pom</artifactId> | ||
| <version>5.4.0-PRE5-SNAPSHOT</version> | ||
| <relativePath>../../hapi-deployable-pom/pom.xml</relativePath> | ||
| </parent> |
There was a problem hiding this comment.
I think that this parent causes the artefact to inherit the groupId ca.uhn.hapi.fhir. I also think that this module will be published to Sonatype. We would need to own this groupId ca.uhn.hapi.fhir to publish to it. Therefore, we need to change this to org.smartregister
There was a problem hiding this comment.
@ekigamba I agree on this. Do we maintain the versioning too or should we reset it too?
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-base</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-server</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-jpaserver-base</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-jaxrsserver-base</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-client</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-client-okhttp</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> |
There was a problem hiding this comment.
Since our approach to Keycloak configuration is not dependent on Hapi FHIR modules, I think that we don't need these
We can also create a new repository for this module. I believe that this is what we follow currently. We ended up splitting the previous OpenSRP server repository into separate and smaller modules each in it's own repository
There was a problem hiding this comment.
Yes, I will be removing these unused dependencies of hapi fhir
There was a problem hiding this comment.
@ekigamba does opensrp-fhir-authentication sound right for the new module?
There was a problem hiding this comment.
@dubdabasoduba Oh! Yea, I am not sure why the fhir work/modules don't have the client/server for each module. But this could also be opensrp-server-fhir-authentication
There was a problem hiding this comment.
@ekigamba thanks. Let me follow up on the repo creation
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-validation-resources-dstu2</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-validation-resources-dstu3</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> |
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-deployable-pom</artifactId> | ||
| <version>5.4.0-PRE5-SNAPSHOT</version> | ||
| <relativePath>../../hapi-deployable-pom/pom.xml</relativePath> | ||
| </parent> |
There was a problem hiding this comment.
@ekigamba I agree on this. Do we maintain the versioning too or should we reset it too?
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-base</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-server</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-jpaserver-base</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-jaxrsserver-base</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-client</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>ca.uhn.hapi.fhir</groupId> | ||
| <artifactId>hapi-fhir-client-okhttp</artifactId> | ||
| <version>${project.version}</version> | ||
| <optional>true</optional> |
| ca.uhn.fhir.jaxrs: debug |
There was a problem hiding this comment.
This might be affected if we rename the group id
closes opensrp/fhircore#40
To build:
hapi-fhir-opensrp-security-configmodule using commandmvn clean -X install -Dmaven.buildNumber.skip=true -Dmaven.test.skip=true