fix: log failed sbom request instead of throw (#2418)

opensource-observer · Oct 25, 2024 · 98cec7b · 98cec7b
1 parent 6d91f4a
commit 98cec7b
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/warehouse/oso_dagster/dlt_sources/github_repos/__init__.py b/warehouse/oso_dagster/dlt_sources/github_repos/__init__.py
@@ -293,9 +293,9 @@ def is_repo_missing_sbom(self, repo: Repository) -> bool:
             )
             return False
         except RequestFailed as e:
-            if e.response.status_code == 404:
-                return True
-            raise e
+            if e.response.status_code != 404:
+                logger.warning("Error checking for SBOM: %s", e)
+            return True
 
     def get_sbom_for_repo(self, repo: Repository) -> List[GithubRepositorySBOMItem]:
         try:
@@ -330,9 +330,10 @@ def get_sbom_for_repo(self, repo: Repository) -> List[GithubRepositorySBOMItem]:
             return sbom_list
         except RequestFailed as exception:
             if exception.response.status_code == 404:
-                logging.warning("Skipping %s, no SBOM found", repo.url)
-                return []
-            raise exception
+                logger.warning("Skipping %s, no SBOM found", repo.url)
+            else:
+                logger.warning("Error getting SBOM: %s", exception)
+            return []
 
     @staticmethod
     def get_github_client(config: GithubClientConfig) -> GitHub: