Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous_integration.yml to disambiguate artifacts on windows #3514

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Jul 14, 2023

Fixes issue #<issue_number>

Brief summary of changes

We build ci on windows 2019 and 2022 but both builds result in the same artifact name causing one to be inaccessible, this PR disambiguates the two.

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because ci

This change is Reviewable

@adamkewley
Copy link
Contributor

Seems simple enough! 👍

@aymanhab
Copy link
Member Author

Thanks @adamkewley

@aymanhab aymanhab merged commit 63f69c6 into main Jul 18, 2023
6 checks passed
@aymanhab aymanhab deleted the aymanhab-patch-artifactnames-win branch July 18, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants