Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE-5098] Support for customizing HAProxy error code response page for http error code 504 #628

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

natlibfi-jonollil
Copy link

@natlibfi-jonollil natlibfi-jonollil commented Oct 15, 2024

I'm not sure if this is enough to make this work. Or should this be against master or next release version?

We have noticed problems regarding error response descriptions with HA-proxy. Problems have been encountered during timeouts and whitelisting as in these cases request produces blank response and this makes debugging work difficult. After finding out the reasons for the problems, we propose adding status codes 504 and 403 to the error responses to help identifying problems with timeouts and access rights in the future.

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 15, 2024
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

Hi @natlibfi-jonollil. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant