-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-43079: [release-4.17] overlay.d/05rhcos: Neuter coreos-luks-open for remote kdump #1634
base: release-4.17
Are you sure you want to change the base?
OCPBUGS-43079: [release-4.17] overlay.d/05rhcos: Neuter coreos-luks-open for remote kdump #1634
Conversation
In cases where kdump is configured to export logs to a remote machine, mounting the local disk is pointless. Furthermore, we can't even do it. This bug was hidden by kdump truncating the arguments but it surfaced in 4.16 with rhkdump/kdump-utils@0f6ad91 See https://issues.redhat.com/browse/OCPBUGS-42351 See coreos/fedora-coreos-config@8ced0db#diff-c55c07c8d9cee0242ef457bc2d5cc254a1c1c1d53f2957378736efe1a98218c1R19
@jbtrystram: This pull request references Jira Issue OCPBUGS-43079, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jbtrystram: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label backport-risk-assessed |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, jbtrystram, mike-nguyen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In cases where kdump is configured to export logs to a remote machine, mounting the local disk is pointless. Furthermore, we can't even do it. This bug was hidden by kdump truncating the arguments but it surfaced in 4.16 with rhkdump/kdump-utils@0f6ad91
See https://issues.redhat.com/browse/OCPBUGS-42351 See coreos/fedora-coreos-config@8ced0db#diff-c55c07c8d9cee0242ef457bc2d5cc254a1c1c1d53f2957378736efe1a98218c1R19
This is a backport of #1632