Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43079: [release-4.17] overlay.d/05rhcos: Neuter coreos-luks-open for remote kdump #1634

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from

Conversation

jbtrystram
Copy link
Contributor

In cases where kdump is configured to export logs to a remote machine, mounting the local disk is pointless. Furthermore, we can't even do it. This bug was hidden by kdump truncating the arguments but it surfaced in 4.16 with rhkdump/kdump-utils@0f6ad91

See https://issues.redhat.com/browse/OCPBUGS-42351 See coreos/fedora-coreos-config@8ced0db#diff-c55c07c8d9cee0242ef457bc2d5cc254a1c1c1d53f2957378736efe1a98218c1R19

This is a backport of #1632

In cases where kdump is configured to export logs to a remote machine,
mounting the local disk is pointless. Furthermore, we can't even do it.
This bug was hidden by kdump truncating the arguments but it surfaced
in 4.16 with rhkdump/kdump-utils@0f6ad91

See https://issues.redhat.com/browse/OCPBUGS-42351
See coreos/fedora-coreos-config@8ced0db#diff-c55c07c8d9cee0242ef457bc2d5cc254a1c1c1d53f2957378736efe1a98218c1R19
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2024
@openshift-ci-robot
Copy link

@jbtrystram: This pull request references Jira Issue OCPBUGS-43079, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-43079 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In cases where kdump is configured to export logs to a remote machine, mounting the local disk is pointless. Furthermore, we can't even do it. This bug was hidden by kdump truncating the arguments but it surfaced in 4.16 with rhkdump/kdump-utils@0f6ad91

See https://issues.redhat.com/browse/OCPBUGS-42351 See coreos/fedora-coreos-config@8ced0db#diff-c55c07c8d9cee0242ef457bc2d5cc254a1c1c1d53f2957378736efe1a98218c1R19

This is a backport of #1632

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@jbtrystram jbtrystram changed the title OCPBUGS-43079: overlay.d/05rhcos: Neuter coreos-luks-open for remote kdump OCPBUGS-43079: [release-4.17] overlay.d/05rhcos: Neuter coreos-luks-open for remote kdump Oct 11, 2024
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

@jbtrystram: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mike-nguyen
Copy link
Member

/label backport-risk-assessed
/label cherry-pick-approved
/lgtm

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Oct 14, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
@dustymabe
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jbtrystram, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dustymabe,jbtrystram,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants