networksegmentation, udn: Wait for NetworkCreated or NetworkReady condition #29381
Conversation
…dition Following the incoming changes of UserDefinedNetwork CRD condition type [1], tests that assert on the NetworkReady condition type should take in account the renamed type NetworkCreated to avoid CI breakage in the following scenarios: - Production code changes reached D/S before tests code changes: Having the UDN CRD produce the new condition type (NetworkCreated), while e2e tests assert on the old condition type (NetworkReady). - Tests code changes reached D/S before production code changes: Having the UDN CRD produce the old condition type (NetworkReady), while tests assert on the new condition type (NetworkCreated). Change assertions on UDN condition type NetworkReady, expect condition type NetworkReady or NetworkCreated. [1] ovn-kubernetes/ovn-kubernetes#4884 Signed-off-by: Or Mergi <[email protected]>
|
/cc @npinaeva |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ormergi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ormergi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
we should run this after ovn-k d/s merge is done to make sure the test works, otherwise it lgtm |
I think the U/S PR wont pass on D/S w/o this PR changes, the D/S merge PR wont pass D/S CI |
|
yep, you can build a cluster with cluster-bot using an ovn-k PR (d/s merge or your own tmp PR) with the status change and run this test against it |
Following the incoming changes of UserDefinedNetwork CRD condition type [1], tests that assert on the NetworkReady condition type should take in account the renamed type NetworkCreated to avoid CI breakage in the following scenarios:
Change assertions on UDN condition type NetworkReady, expect condition type NetworkReady or NetworkCreated.
[1] ovn-kubernetes/ovn-kubernetes#4884