daemon sets: use standardized tolerations for platform ds #29343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed OpenShift has an issue with platform daemon sets and infra nodes. The infra nodes are tainted as NoSchedule, to avoid customer workloads on them. However, platform workloads should run there, but two daemon sets (iptables-alerter and dns-default) don't tolerate all taints, unlike most daemon sets, which use:
Instead, they use:
This prevents these pods from running on infra nodes. However, these DS are also marked
PreferredDuringScheduling
which can cause the tolerations to be ignored (why do we use this?) triggering frequent KubeDaemonSetMisScheduled alerts, disrupting SREs and CI, and blocking ROSA payload readiness.PRs to fix this:
This PR enforces the first style.
/hold
Pending discussion