Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon sets: use standardized tolerations for platform ds #29343

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Dec 4, 2024

Managed OpenShift has an issue with platform daemon sets and infra nodes. The infra nodes are tainted as NoSchedule, to avoid customer workloads on them. However, platform workloads should run there, but two daemon sets (iptables-alerter and dns-default) don't tolerate all taints, unlike most daemon sets, which use:

tolerations:
- operator: Exists

Instead, they use:

tolerations:
- key: "node-role.kubernetes.io/master"
  operator: "Exists"

This prevents these pods from running on infra nodes. However, these DS are also marked PreferredDuringScheduling which can cause the tolerations to be ignored (why do we use this?) triggering frequent KubeDaemonSetMisScheduled alerts, disrupting SREs and CI, and blocking ROSA payload readiness.

PRs to fix this:

This PR enforces the first style.

/hold
Pending discussion

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2024
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@candita
Copy link
Contributor

candita commented Dec 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants