OCPBUGS-43777: apiserver: add tests to verify kube-apiserver is accessible via different endpoints #29339

vrutkovs · 2024-12-03T13:40:14Z

Add tests which check that kube-apiserver is reachable via service network, external and internal api endpoints

TODO:

Fix kube-apiserver should be accessible via service network endpoint failing in pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6

openshift-ci-robot · 2024-12-03T13:40:20Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-43777, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add tests which check that kube-apiserver is reachable via service network, external and internal api endpoints

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vrutkovs · 2024-12-04T10:40:10Z

/retest

openshift-trt · 2024-12-04T15:26:36Z

Job Failure Risk Analysis for sha: 6252a14

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout	IncompleteTests Tests for this run (103) are below the historical average (1373): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (103) are below the historical average (2601): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn	IncompleteTests Tests for this run (103) are below the historical average (2397): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	IncompleteTests Tests for this run (102) are below the historical average (2746): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

everettraven · 2024-12-04T16:15:35Z

test/extended/apiserver/access.go

+				} else {
+					apiPath = strings.Replace(externalAPIUrl.Host, "api.", "api-int.", 1)
+				}


Is api-int.* always going to resolve to the internal API server endpoint?

Would pulling the internal API server URL using infra.Status.APIServerInternalURL be more reflective of the flow that a user/client may attempt to take if they were to look at the Infrastructure API?

Yes, good point. iiuc Hypershift may use a different URL for internal URL

Fixed in e1fd7a8

openshift-trt · 2024-12-05T12:11:06Z

Job Failure Risk Analysis for sha: e1fd7a8

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial	Medium [bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info This test has passed 97.73% of 44 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-serial'] in the last 14 days. Open Bugs alert/KubeAPIErrorBudgetBurn should not be at or above info
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	Low [sig-node] static pods should start after being created This test has passed 70.73% of 164 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. Open Bugs Static pod controller pods sometimes fail to start [etcd] --- [sig-node] static pods should start after being created This test has passed 70.73% of 164 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. Open Bugs Static pod controller pods sometimes fail to start [etcd]

openshift-trt · 2024-12-05T16:32:17Z

Job Failure Risk Analysis for sha: c030cf7

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade	Low [sig-node] static pods should start after being created This test has passed 71.07% of 159 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. Open Bugs Static pod controller pods sometimes fail to start [etcd] --- [sig-node] static pods should start after being created This test has passed 71.07% of 159 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week. Open Bugs Static pod controller pods sometimes fail to start [etcd]

everettraven

Changes look reasonable to me.

/lgtm

openshift-ci · 2024-12-05T16:51:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everettraven, vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add tests which check that kube-apiserver is reachable via service network, external and internal api endpoints

openshift-ci · 2024-12-06T11:00:57Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2024-12-06T15:23:07Z

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade	`587d445`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-metal-ipi-ovn	`587d445`	link	false	`/test e2e-metal-ipi-ovn`
ci/prow/e2e-agnostic-ovn-cmd	`587d445`	link	false	`/test e2e-agnostic-ovn-cmd`
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout	`587d445`	link	false	`/test e2e-metal-ipi-ovn-kube-apiserver-rollout`
ci/prow/e2e-aws-ovn-kube-apiserver-rollout	`587d445`	link	false	`/test e2e-aws-ovn-kube-apiserver-rollout`
ci/prow/okd-scos-e2e-aws-ovn	`587d445`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-metal-ipi-ovn-ipv6	`587d445`	link	true	`/test e2e-metal-ipi-ovn-ipv6`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt · 2024-12-06T15:49:05Z

Job Failure Risk Analysis for sha: 587d445

Job Name	Failure Risk
pull-ci-openshift-origin-master-okd-scos-e2e-aws-ovn	IncompleteTests Tests for this run (20) are below the historical average (2329): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 3, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 3, 2024

openshift-ci bot requested review from wangke19, c3d and sjenning December 3, 2024 13:40

vrutkovs force-pushed the access-kube-apiserver branch from 24188fa to 6252a14 Compare December 3, 2024 14:22

vrutkovs changed the title ~~OCPBUGS-43777: apiserver: add tests to verify login via various methods~~ OCPBUGS-43777: apiserver: add tests to verify kube-apiserver is accessible via different endpoints Dec 4, 2024

everettraven reviewed Dec 4, 2024

View reviewed changes

vrutkovs force-pushed the access-kube-apiserver branch from 6252a14 to e1fd7a8 Compare December 5, 2024 08:18

vrutkovs force-pushed the access-kube-apiserver branch from e1fd7a8 to c030cf7 Compare December 5, 2024 12:40

everettraven approved these changes Dec 5, 2024

View reviewed changes

openshift-ci bot assigned everettraven Dec 5, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024

apiserver: add tests to verify login via various methods

587d445

Add tests which check that kube-apiserver is reachable via service network, external and internal api endpoints

vrutkovs force-pushed the access-kube-apiserver branch from c030cf7 to 587d445 Compare December 6, 2024 11:00

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-43777: apiserver: add tests to verify kube-apiserver is accessible via different endpoints #29339

OCPBUGS-43777: apiserver: add tests to verify kube-apiserver is accessible via different endpoints #29339

vrutkovs commented Dec 3, 2024 •

edited

Loading

openshift-ci-robot commented Dec 3, 2024

vrutkovs commented Dec 4, 2024

openshift-trt bot commented Dec 4, 2024

everettraven Dec 4, 2024

vrutkovs Dec 4, 2024

vrutkovs Dec 5, 2024 •

edited

Loading

openshift-trt bot commented Dec 5, 2024

openshift-trt bot commented Dec 5, 2024

everettraven left a comment

openshift-ci bot commented Dec 5, 2024

openshift-ci bot commented Dec 6, 2024

openshift-ci bot commented Dec 6, 2024

openshift-trt bot commented Dec 6, 2024

OCPBUGS-43777: apiserver: add tests to verify kube-apiserver is accessible via different endpoints #29339

Are you sure you want to change the base?

OCPBUGS-43777: apiserver: add tests to verify kube-apiserver is accessible via different endpoints #29339

Conversation

vrutkovs commented Dec 3, 2024 • edited Loading

openshift-ci-robot commented Dec 3, 2024

vrutkovs commented Dec 4, 2024

openshift-trt bot commented Dec 4, 2024

everettraven Dec 4, 2024

Choose a reason for hiding this comment

vrutkovs Dec 4, 2024

Choose a reason for hiding this comment

vrutkovs Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

openshift-trt bot commented Dec 5, 2024

openshift-trt bot commented Dec 5, 2024

everettraven left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 5, 2024

openshift-ci bot commented Dec 6, 2024

openshift-ci bot commented Dec 6, 2024

openshift-trt bot commented Dec 6, 2024

vrutkovs commented Dec 3, 2024 •

edited

Loading

vrutkovs Dec 5, 2024 •

edited

Loading