OCPBUGS-38749: add retry on error for apply functions

[djoshy]

- What I did
Adds a retry on error for applying the MCC deployment, the MCD daemonset and the MCS daemonset. I also took this opportunity to clean up some pointer library references.

- How to verify it
These error logs mentioned in the bug is quite rare, so it may be hard to verify this. Regardless, it should help clean up such failures.

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-38749, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
Adds a retry on error for applying the MCC deployment, the MCD daemonset and the MCS daemonset. I also took this opportunity to clean up some pointer library references.

- How to verify it
These error logs mentioned in the bug is quite rare, so it may be hard to verify this. Regardless, it should help clean up such failures.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/jira refresh

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-38749, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[djoshy]

/test unit

[sergiordlr]

To pre-merge verify this job we will execute critical test cases
https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-longduration-mco-critical-f9/1857361740874911744 (currently running)

Once the fix is merged we can wait some time before moving the status to verified, and post-merge verify that the error is not present anymore in the CI after the merge date.

[djoshy]

/test unit

[sergiordlr]

New critical testrun execution https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-aws-ipi-longduration-mco-critical-f9/1857459183297761280

[openshift-ci]

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift	a44acc2	link	true	/test e2e-hypershift
ci/prow/okd-scos-e2e-aws-ovn	a44acc2	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade	a44acc2	link	true	/test e2e-aws-ovn-upgrade
ci/prow/e2e-azure-ovn-upgrade-out-of-change	a44acc2	link	false	/test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.