Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCO-1165: rebuild annotation #4694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cheesesashimi
Copy link
Member

- What I did

I added the ability for a cluster admin to request that the currently active
MachineOSBuild be rebuilt. This is done by adding the annotation
machineconfiguration.openshift.io/rebuild to the MachineOSConfig.

- How to verify it

  1. Bring up an OpenShift cluster.
  2. Opt into on-cluster layering by creating a MachineOSConfig.
  3. Wait for the build to complete.
  4. Add the annotation machineconfiguration.openshift.io/rebuild onto the MachineOSConfig.
  5. The controller should delete the current MachineOSBuild and a new one should be started in its place.

- Description for the changelog
Adds rebuild functionality for OCL

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2024

@cheesesashimi: This pull request references MCO-1165 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

- What I did

I added the ability for a cluster admin to request that the currently active
MachineOSBuild be rebuilt. This is done by adding the annotation
machineconfiguration.openshift.io/rebuild to the MachineOSConfig.

- How to verify it

  1. Bring up an OpenShift cluster.
  2. Opt into on-cluster layering by creating a MachineOSConfig.
  3. Wait for the build to complete.
  4. Add the annotation machineconfiguration.openshift.io/rebuild onto the MachineOSConfig.
  5. The controller should delete the current MachineOSBuild and a new one should be started in its place.

- Description for the changelog
Adds rebuild functionality for OCL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 12, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2024
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
By adding an annotation to a MachineOSConfig object, a cluster admin
will be able to cause a rebuild to occur.
@cheesesashimi cheesesashimi marked this pull request as ready for review November 13, 2024 13:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 9e106a1 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change 9e106a1 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift 9e106a1 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sergiordlr
Copy link

Hello! it looks like that the DoARebuild in the helpers.go file is not used anymore. Should we remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants