[release-4.17] OCPBUGS-43719: Soften haproxy timeout for kubeapi probe #4657
Conversation
This PR changes timeouts used by haproxy when deciding whether the master backend (i.e. k8s api server) is dead or alive. The previous probe was relatively strict, allowing for a very fast failover but at the same time very prone to temporary flakiness. The new configuration aligns haproxy with the readiness probe used by k8s when detecting if pod is dead or alive. Aligning those configurations removes the mismatch we have when k8s believes api server is ready but haproxy sees it as dead. A consequence of this change is a potential increase of the downtime when api server is forcefully removed. In the worst case scenario we may see unavailability for 15 seconds. This should not be happening much in a real setups, but for the sake of completeness this should be noted. Fixes: OCPBUGS-43428
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-43428 has been cloned as Jira Issue OCPBUGS-43719. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43719, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @deads2k Your call if you want the change in 4.17 too |
deads2k
added
approved
|
/lgtm |
deads2k
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, eurijon, mburman5, mhanss, ptalgulk01, rbbratta, reihl, rioliu-rh and rlobillo
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: deads2k, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
All the way back to 4.14 please. |
|
/jira refresh |
|
@deads2k: This pull request references Jira Issue OCPBUGS-43719, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
deads2k
added
cherry-pick-approved
|
/jira cherry-pick release-4.16,release-4.15,release-4.14 |
|
/jira backport release-4.16,release-4.15,release-4.14 |
|
@mkowalski: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Will mark original as verified once we have a couple days data here |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@deads2k: This pull request references Jira Issue OCPBUGS-43719, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit c1e2223
into
openshift:release-4.17
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-43719: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-43719 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #4662 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci-robot: new pull request created: #4663 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci-robot: new pull request created: #4664 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
This is an automated cherry-pick of #4646
/assign mkowalski