OCPBUGS-39404: Enable TLS by default between Metal3's httpd server and the BMC (for serving virtual media images) #9170
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@MahnoorAsghar: This pull request references Jira Issue OCPBUGS-39404, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
@MahnoorAsghar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| templateData.DisableIronicVirtualMediaTLS = true | ||
| protocol := "http" | ||
| // The default value is 'false'. | ||
| templateData.DisableIronicVirtualMediaTLS = false |
There was a problem hiding this comment.
nit: not needed, false is the default for booleans in Go
|
/approve Please make sure the bug has a release note that mentions the change (I suspect we use a different port? To be investigated) and how to revert it. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
We need enable TLS between the BMC and the Metal3's httpd server for OCP 4.18+, for consistency with CBO-deployed Metal3.